Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wayland] Keyboard stopped working on master #4767

Closed
2 tasks done
clotodex opened this issue Apr 15, 2024 · 9 comments · Fixed by #4768
Closed
2 tasks done

[wayland] Keyboard stopped working on master #4767

clotodex opened this issue Apr 15, 2024 · 9 comments · Fixed by #4768

Comments

@clotodex
Copy link

Issue description

I updated to the newest version and found myself not being able to use the keyboard (using wayland). The mouse still worked.
I created the issue for awareness and will help debug this in the next few days.
Not working on: 0.25.1.dev5+ga890670d
Reverted back to: 0.23.1.dev65+g2e89b757 (working here, with the rest of the system identical)

Gentoo Kernel: 6.8.6-gentoo-dist #1 SMP PREEMPT_DYNAMIC Sat Apr 13 15:30:53 -00 2024 x86_64 12th Gen Intel(R) Core(TM) i9-12900H GenuineIntel GNU/Linux

Thank you for your hard work on this!

Version

master - 0.25.1.dev5+ga890670d

Backend

Wayland (experimental)

Config

No response

Logs

No response

Required

  • I have searched past issues to see if this bug has already been reported, and it hasn't been.
  • I understand that people give their precious time for free, and thus I've done my very best to make this problem as easy as possible to investigate.
@jwijenbergh
Copy link
Contributor

jwijenbergh commented Apr 15, 2024

Does nothing of the keyboard work? What about another keyboard? Did you check ~/.local/share/qtile/qtile.log?

@clotodex
Copy link
Author

I checked the logs, nothing out of the ordinary
I can try out an external keyboard (i am on a laptop)

@cr1ogen
Copy link

cr1ogen commented Apr 15, 2024

i have the same problem, this is my qtile.log

Traceback (most recent call last):
  File "/usr/local/lib/python3.11/dist-packages/pywayland/server/listener.py", line 40, in notify_func
    callback(listener, data)
  File "/usr/local/lib/python3.11/dist-packages/libqtile/backend/wayland/core.py", line 438, in _on_new_input
    device = self._add_new_keyboard(wlr_device)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/dist-packages/libqtile/backend/wayland/core.py", line 1156, in _add_new_keyboard
    device = inputs.Keyboard(self, wlr_device, keyboard)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/dist-packages/libqtile/backend/wayland/inputs.py", line 210, in __init__
    self.qtile = core.qtile
                 ^^^^^^^^^^
  File "/usr/local/lib/python3.11/dist-packages/libqtile/command/base.py", line 281, in __getattr__
    raise AttributeError(f"{self.__class__} has no attribute {name}")
AttributeError: <class 'libqtile.backend.wayland.core.Core'> has no attribute qtile
2024-04-15 17:48:30,415 ERROR pywayland.server listener.py:notify_func():L42 Exception in callback function
Traceback (most recent call last):
  File "/usr/local/lib/python3.11/dist-packages/pywayland/server/listener.py", line 40, in notify_func
    callback(listener, data)
  File "/usr/local/lib/python3.11/dist-packages/libqtile/backend/wayland/core.py", line 449, in _on_new_input
    if self.qtile:
       ^^^^^^^^^^
  File "/usr/local/lib/python3.11/dist-packages/libqtile/command/base.py", line 281, in __getattr__
    raise AttributeError(f"{self.__class__} has no attribute {name}")
AttributeError: <class 'libqtile.backend.wayland.core.Core'> has no attribute qtile
2024-04-15 17:48:30,521 WARNING libqtile prompt.py:_configure():L440 Prompt widget only supports audible bell under X11
2024-04-15 17:48:30,521 WARNING libqtile core.py:set_keymap():L1545 Could not set keymap: no keyboards set up.
2024-04-15 17:48:30,545 WARNING libqtile core.py:set_keymap():L1545 Could not set keymap: no keyboards set up.
2024-04-15 17:48:33,384 WARNING libqtile core.py:set_keymap():L1545 Could not set keymap: no keyboards set up.
2024-04-15 17:48:43,314 WARNING libqtile core.py:set_keymap():L1545 Could not set keymap: no keyboards set up.

@jwijenbergh
Copy link
Contributor

can repro, investigating...

jwijenbergh added a commit to jwijenbergh/qtile that referenced this issue Apr 15, 2024
In qtile#4757 we have fixed some of the logic with regards to setting
self.qtile. This means that in certain scenarios the self.qtile
attribute does not exist, e.g. when we're adding keyboards befor the
config is loaded.

We already mark these devices as "pending" if
self.qtile is `None`, but this now does not work as the attribute is not
set in the first place. Let's check with hasattr and remove the
unneeded self.qtile setting inside of the keyboard constructor.

This fixes qtile#4767
@jwijenbergh
Copy link
Contributor

Try #4768

jwijenbergh added a commit to jwijenbergh/qtile that referenced this issue Apr 15, 2024
In qtile#4757 we have fixed some of the logic with regards to setting
self.qtile. This means that in certain scenarios the self.qtile
attribute does not exist, e.g. when we're adding keyboards before the
config is loaded.

We already mark these devices as "pending" if
self.qtile is `None`, but this now does not work as the attribute is not
set in the first place. Let's check with hasattr and remove the
unneeded self.qtile setting inside of the keyboard constructor.

This fixes qtile#4767
@cr1ogen
Copy link

cr1ogen commented Apr 15, 2024

Try #4768

How I do it? Sorry

tych0 pushed a commit that referenced this issue Apr 15, 2024
In #4757 we have fixed some of the logic with regards to setting
self.qtile. This means that in certain scenarios the self.qtile
attribute does not exist, e.g. when we're adding keyboards before the
config is loaded.

We already mark these devices as "pending" if
self.qtile is `None`, but this now does not work as the attribute is not
set in the first place. Let's check with hasattr and remove the
unneeded self.qtile setting inside of the keyboard constructor.

This fixes #4767
@cr1ogen
Copy link

cr1ogen commented Apr 16, 2024

Thanks!!!

@jwijenbergh
Copy link
Contributor

Try #4768

How I do it? Sorry

Don't worry about it. Should be fixed in master now

@clotodex
Copy link
Author

Nice it works again, thank you <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants