Add mute and unmute formats for Volume and PulseVolume widgets

[shyguyCreate]

Rewrite of #4151

[github-actions]

Thank you for opening your first PR into Qtile!
If you have not heard from us in a while, please feel free to ping one of the devs or anyone who has commented on the PR, as sometimes things fall through the cracks.
You can also join the chat room for real-time discussion, see the community links.
For details on what PRs might need to include before we will merge them please see the docs.

[shyguyCreate]

Help. Can someone point me out how to get the PulseAudio volume value when mute, it always returns -1.

I can't find anything in pulse_volume.py.

EDIT: Found it.

[elParaguayo]

Agree with @tych0 - this needs some work. Having get_volume() return a tuple of the volume level and whether the device is muted or not seems like the correct approach.

[elParaguayo]

I think this would be a nice addition to the code. However, I'm marking this one as "request changes` for now because:
a) it needs changes as suggested by tych0
b) the volume widgets are likely to be used by a large portion of the userbase so I want to take a close look before this gets merged.

[elParaguayo]

Why close this?

[shyguyCreate]

Sorry I panic, I think I messed up the commit history.

[elParaguayo]

Don't worry about that. Keep going!

[shyguyCreate]

For the record, I did messed up the history right? Because I see 10+ commits that are not mine.

[elParaguayo]

If you look at this PR page you'll see it says it's only adding one commit. The other ones were probably because you did a merge to bring the branch in line with the current master. However, github knows those commits aren't needed here.

[shyguyCreate]

Next time I have to update the master I'll ask before undoing everything.

[elParaguayo]

Just rebase onto master rather than try to merge changes into the branch.

[shyguyCreate]

Question: I have heard bad things about using --force on push, and after playing with git rebase and getting my commit on top, I really need to use --force with git push?

[elParaguayo]

There are definitely times when you shouldn't use force (eg when pushing to a branch that other users are tracking and making changes to). However, for a PR here, we're happy for you to use force.

[shyguyCreate]

All right, thanks

[tych0]

Thanks!

[elParaguayo]

This broke the Volume widget. We had a method called mute (which is called by clicking on the widget) but this is overwritten by defining a variable called mute during __init__.

We need better tests!

[shyguyCreate]

It should now be fixed in the new PR.