move stack dump handler #4780
move stack dump handler #4780
Conversation
We set this up in main, but our test suite never calls qtile's main method, so my attempts at logging why tests were hanging would never succeed. Instead, let's set this up in async_loop() where we set up the other signal handling, which is called by the test suite and hopefully as a result will yield stack traces when our test suite hangs. Fixes qtile#4778 Signed-off-by: Tycho Andersen <tycho@tycho.pizza>
|
Thanks. This also seems to fix the weird issue I had with errors appearing in |
oh, duh. because when you resize your terminal, that sends a SIGWINCH which we were also using to dump stacks. I wonder: should we use SIGUSR2 instead? We were previously using it for reloading, but I bet that nobody was actually using it for reloading (probably everyone just picked SIGUSR1), so I don't think it would break anything. And it wouldn't have any strange unintended consequences like SIGWINCH does. |
|
SIGUSR2 would make more sense. There's no real reason for using it to reload the config as that can be triggered via IPC anyway. |
|
Ok, I will send a patch if you don't beat me to it :) |
|
All yours, I'm working on something else! |
We set this up in main, but our test suite never calls qtile's main method, so my attempts at logging why tests were hanging would never succeed.
Instead, let's set this up in async_loop() where we set up the other signal handling, which is called by the test suite and hopefully as a result will yield stack traces when our test suite hangs.
Fixes #4778