Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document release steps #4829

Merged
merged 1 commit into from
Jun 2, 2024
Merged

document release steps #4829

merged 1 commit into from
Jun 2, 2024

Conversation

tych0
Copy link
Member

@tych0 tych0 commented May 22, 2024

I realized a lot of this is just in my bash history and stuff I've stumbled over. I'm sure other people know this, I'm mostly just writing it down for reference next time I need to tag a release.

I didn't add it to the table of contents or anything since I don't think any users really care, but I can if people think it's useful.

Copy link
Member

@elParaguayo elParaguayo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. I've added some suggestions.

docs/manual/releasing.rst Outdated Show resolved Hide resolved
2. Create a GPG-signed annotated tag (``git commit -a -s``); I usually just use
exactly the same commit message as the actual release commit above.

3. Push your release commit to git master and your tag.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to say you're pushing straight to upstream rather than your fork? Would be good to give command line here too.

exactly the same commit message as the actual release commit above.

3. Push your release commit to git master and your tag.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before creating the release, we should check the action that builds the wheels and pushes these to test.pypi. This is triggered by the tag being pushed. If that's green then we can create the release.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! I think I knew this, but I totally forgot to do it for the most recent release. I will make a note.

@tych0
Copy link
Member Author

tych0 commented May 26, 2024

Ok, take a look now and see what you think.


.. bash::

git push origin vX.XX.XX
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me, origin is my fork, upstream is the main qtile repo...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the risk of writing explicit git commands :). Should I drop them? Or what do you prefer?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe remove the example and be more explicit in line 22 e.g. adding something like ... as opposed to your fork

docs/manual/releasing.rst Outdated Show resolved Hide resolved

8. send a mail to qtile-dev@googlegroups.com; I sometimes just use
git-send-email with the release commit, but a manual copy/paste of the
release notes into an e-mail is fine as well.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A message via IRC/Discord would be good too.

I realized a lot of this is just in my bash history and stuff I've stumbled
over. I'm sure other people know this, I'm mostly just writing it down for
reference next time I need to tag a release.

I didn't add it to the table of contents or anything since I don't think
any users really care, but I can if people think it's useful.

Signed-off-by: Tycho Andersen <tycho@tycho.pizza>
@elParaguayo elParaguayo merged commit 55cf2ed into qtile:master Jun 2, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants