bar: finalize drawer before recreating it #4842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If there is a |
...instead, just resize it. If we re-create it, we'll leak the resources attached, and that's bad. This is another leak that I found while looking for the source of qtile#4821. Signed-off-by: Tycho Andersen <tycho@tycho.pizza>
tych0
force-pushed
the
finalize-redo-drawer
branch
from
b42eee5
to
58d46af
Compare
|
Ok, I switched it to just set width+height if it already exists. Hopefully it looks reasonable now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the drawer previously existed, we need to .finalize() it, or we'll leak its resources.
The comment about the stated reason for this is a little strange: we have width and height setters here, can we not just set them and not re-create the drawer at all? Thoughts welcome.
This is another leak that I found while looking for the source of #4821.