Use some new xcffib api #536
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flacjacket
force-pushed
the
cffi-new-xcffib-api
branch
2 times, most recently
from
969cfa4
to
ad600e4
Compare
flacjacket
force-pushed
the
cffi-new-xcffib-api
branch
from
ad600e4
to
f6459ab
Compare
|
I've updated this to just include the commit that was reverted, I'll update when I get around to figuring out what is wrong with it. |
flacjacket
force-pushed
the
cffi-new-xcffib-api
branch
from
f6459ab
to
ff24325
Compare
flacjacket
force-pushed
the
cffi-new-xcffib-api
branch
from
ff24325
to
0d74c35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses some of the new stuff available in xcffib not in xpyb, namely
.to_atoms()and.to_strings()to parse returned values and using synthetic events. Using the git xcffib, the tests pass fine for me, however, Travis seems to have some problems with the synthetic events. Not even sending them, but just packing them. Using only 7e7cab2, which just tries to pack the data and compare it to the struct packed data causes Travis to hang https://travis-ci.org/flacjacket/qtile/builds/39116342. I have no way of saying where this is coming from.