-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
should fix linux watch mode #256
Conversation
not fixed: it seems that with |
OK. one bug fixed, one bug received:
|
also, |
_command = subprocess.Popen('stty size', stdout=subprocess.PIPE, stderr=subprocess.PIPE, shell=True) | ||
tty_size, _error = _command.communicate() | ||
if not _error: | ||
term_height, term_columns = [int(x) for x in tty_size.strip().split()] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
map(int, tty_size.strip().split())
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
afaik, list comps are preferred to map
read_char = wait_for_keypress_or_autorefresh(viewport, int(options.WATCH[0]) or KEYPRESS_TIMEOUT) | ||
control_qtop(viewport, read_char, cluster) | ||
read_char = wait_for_keypress_or_autorefresh(viewport, FALLBACK_TERMSIZE, int(options.WATCH[0]) or | ||
KEYPRESS_TIMEOUT) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the way your editor tells you: "you have far too long function name" ;-)
lgtm, both in source and output; merging! |
No description provided.