check jobid consistency between input files in OAR #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgeorgatos
reviewed
Dec 7, 2016
| @@ -2163,7 +2163,7 @@ class InvalidScheduler(Exception): | |||
|
|
|||
| job_ids, user_names, job_states, job_queues = scheduling_system.get_jobs_info() | |||
| total_running_jobs, total_queued_jobs, qstatq_lod = scheduling_system.get_queues_info() # callthis elsewhere | |||
| worker_nodes = scheduling_system.get_worker_nodes() | |||
| worker_nodes = scheduling_system.get_worker_nodes(job_ids) | |||
There was a problem hiding this comment.
any impact on performance by these changes? (just asking...)
|
not too much, I added a check in a list comprehension. if we have to state
the discrepancy explicitly though, it might impact the performance a little
bit.
…On Dec 7, 2016 2:30 PM, "Fotis Georgatos" ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In qtop.py
<#258 (review)>:
> @@ -2163,7 +2163,7 @@ class InvalidScheduler(Exception):
job_ids, user_names, job_states, job_queues = scheduling_system.get_jobs_info()
total_running_jobs, total_queued_jobs, qstatq_lod = scheduling_system.get_queues_info() # callthis elsewhere
- worker_nodes = scheduling_system.get_worker_nodes()
+ worker_nodes = scheduling_system.get_worker_nodes(job_ids)
any impact on performance by these changes? (just asking...)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#258 (review)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABdZk3NptgzF8JBq6suDMoP_3b6EI5Egks5rFqbUgaJpZM4LGbJy>
.
|
sfranky
changed the title
|
This PR should also result in some minor performance improvement, mostly memory-wise. |
|
lgtm, tests pass and seems to work without issues (tbv) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for bug #249