Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACF setting fields not translatable in group fields #1255

Closed
herrvigg opened this issue Nov 20, 2022 · 2 comments
Closed

ACF setting fields not translatable in group fields #1255

herrvigg opened this issue Nov 20, 2022 · 2 comments
Labels
module: ACF Integration with ACF severity: major Major functionality

Comments

@herrvigg
Copy link
Collaborator

herrvigg commented Nov 20, 2022 •
edited
Loading

With the option "translation of standard field types" enabled, the setting fields "labels, description and default value" used to be translatable in the group field pages.

This regression can be seen with ACF 5.12 so it's not a news with ACF6. It's unclear when it happened but it's surely due to changes in UI for an open/close design. The JS code in QTX should use some events.
@herrvigg herrvigg added the module: ACF Integration with ACF label Nov 20, 2022
@herrvigg herrvigg changed the title ACF meta fields not translatable in group fields ACF setting fields not translatable in group fields Nov 20, 2022
herrvigg added a commit that referenced this issue Nov 23, 2022
@herrvigg
Fix ACF translatable standard settings (#1255)
0e96dfa 
Major fix for the support of generic translatable ACF settings such
as label, description and default value.

Use undocumented `open_field_object`, works with ACF5.12.4 and ACF6.

Delete obsolete ACF `append_field` JS hook.
Anyway the hook for wysiwyg editor is currently broken (#1186).
@herrvigg herrvigg mentioned this issue Nov 23, 2022
Closed
@herrvigg
Copy link
Collaborator Author

Fixed in master, please try this before upcoming release. This enables back many integration features with ACF, tested with ACF 5.12.4 and ACF 6.0.5.

The hook with the standard wysiwyg editor is still broken but that's a separate issue #1186. The qTranslate wysiwyg field should be working.

@herrvigg herrvigg mentioned this issue Nov 23, 2022
Closed
herrvigg added a commit that referenced this issue Nov 24, 2022
@herrvigg
Fix ACF display in taxonomy (#908)
3b3db28 
Related to #1255 but the parent for the description is
under `.acf-input` vs `.acf-label` in general.

Make the selectors more specific to limit search under
direct child only.
@herrvigg herrvigg mentioned this issue Nov 24, 2022
Closed
herrvigg added a commit that referenced this issue Nov 27, 2022
@herrvigg
Fix API call in ACF with addContentHookB (#1255)
19e4b08
@herrvigg herrvigg added the severity: major Major functionality label Nov 27, 2022
@MarkArgent MarkArgent mentioned this issue Dec 1, 2022
Closed
herrvigg added a commit that referenced this issue Dec 4, 2022
@herrvigg
Fix wysiwyg_tinymce_settings filter (#1255)
7bb61c6 
Content hooks must not be set on `qtranslate_wysiwyg` fields (QTX).
It must be limited to standard ACF `wysiwyg` type fields.
@herrvigg
Copy link
Collaborator Author

Released in 3.13.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
module: ACF Integration with ACF severity: major Major functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@herrvigg