Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undefined array key "domains" when setting URL per-domain #1319

Closed
herrvigg opened this issue Apr 11, 2023 · 1 comment
Closed

Undefined array key "domains" when setting URL per-domain #1319

herrvigg opened this issue Apr 11, 2023 · 1 comment
Labels
bug Something isn't working, reproducible core Core functionalities, including the admin section severity: minor Minor functionality

Comments

@herrvigg
Copy link
Collaborator

Change URL modification mode from any to "Use Per-Domain" (3rd) generates this warning:

Warning: Undefined array key "domains" in /var/www/html/wp-content/plugins/qtranslate-xt/src/url.php on line 503

This warning with the options must have been there for very long. Not obvious how to test this mode but this should be fixed.
@herrvigg herrvigg added bug Something isn't working, reproducible core Core functionalities, including the admin section severity: minor Minor functionality labels Apr 11, 2023
@herrvigg herrvigg changed the title Undefined array key "domains" with URL per-domain (user-defined) Undefined array key "domains" when setting URL per-domain Apr 15, 2023
herrvigg added a commit that referenced this issue Apr 15, 2023
@herrvigg
Fix undefined keys when URL mode set to per-domain (#1319)
1e75bc1 
When changing URL mode to per-domain (user setting), the `domains`
configuration is not properly loaded which triggers some errors in
some URL functions.

Fix the option update to reload the value.
Fix empty domain given by user, reset to default value per domain.
Robustify the URL functions reading the `domains` config.
@herrvigg
Copy link
Collaborator Author

Released in 3.15.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working, reproducible core Core functionalities, including the admin section severity: minor Minor functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@herrvigg