Modification of qtrans_parseURL and qtrans_use written by normadize to i...

[herrvigg]

Issue by janbernloehr
Wednesday Jan 14, 2015 at 12:43 GMT
Originally opened as qTranslate-Team/qtranslate-x#7

---

...mprove performance -- see https://wordpress.org/support/topic/evidence-on-how-slow-and-inefficient-qtranslate-is-please-do-something.

---

janbernloehr included the following code: https://github.com/qTranslate-Team/qtranslate-x/pull/7/commits

[herrvigg]

Comment by LC43
Wednesday Jan 14, 2015 at 16:20 GMT

---

we used much of those modifications on our own qts_use and use parse_url for our parser too. can't say much for performance gain, but using a native function is always a good choice.

[herrvigg]

Comment by johnclause
Friday Jan 16, 2015 at 23:26 GMT

---

Thank you, Jan and Pedro, this is very useful information. I keep finding more and more imperfections too. I will research it all together when I am ready to work on performance issues, after I am done with other recent "fires", reported by users.

[herrvigg]

Comment by johnclause
Friday Jan 16, 2015 at 23:30 GMT

---

BTW, if you got some spare time, you might be curious to solve qTranslate-Team/qtranslate-x#5 . It was always there since original qTranslate and including mqTranslate, and, I would assume, all other forks too.

[herrvigg]

Comment by xhaleera
Sunday Feb 15, 2015 at 10:43 GMT

---

I've tried parse_url on mqTranslate a few months ago, but some users get altered behavior and errors, so I reverted to the "original" qtrans_parseURL

[herrvigg]

Comment by johnclause
Sunday Feb 15, 2015 at 18:54 GMT

---

Yes, I also figured out that it is not exactly the same, and cannot replace the current implementation without further changes. Besides, this part of code in -x has already been modified a lot, and this PR is no longer applicable. I am closing it now. Thank you, @janmolnar, for submitting it though it was very useful to inspire some ideas.