Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modification of qtrans_parseURL and qtrans_use written by normadize to i... #7

Closed
wants to merge 1 commit into from

Conversation

janbernloehr
Copy link

@LC43
Copy link

LC43 commented Jan 14, 2015

we used much of those modifications on our own qts_use and use parse_url for our parser too. can't say much for performance gain, but using a native function is always a good choice.

@johnclause
Copy link
Member

Thank you, Jan and Pedro, this is very useful information. I keep finding more and more imperfections too. I will research it all together when I am ready to work on performance issues, after I am done with other recent "fires", reported by users.

@johnclause
Copy link
Member

BTW, if you got some spare time, you might be curious to solve #5 . It was always there since original qTranslate and including mqTranslate, and, I would assume, all other forks too.

@chsxf
Copy link
Contributor

chsxf commented Feb 15, 2015

I've tried parse_url on mqTranslate a few months ago, but some users get altered behavior and errors, so I reverted to the "original" qtrans_parseURL

@johnclause
Copy link
Member

Yes, I also figured out that it is not exactly the same, and cannot replace the current implementation without further changes. Besides, this part of code in -x has already been modified a lot, and this PR is no longer applicable. I am closing it now. Thank you, @janmolnar, for submitting it though it was very useful to inspire some ideas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants