Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minority languages and three letter codes #836

Closed
mikoet opened this issue May 8, 2020 · 4 comments
Closed

Minority languages and three letter codes #836

mikoet opened this issue May 8, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@mikoet
Copy link

mikoet commented May 8, 2020

I want to use this plugin for a website that will contain content in Low Saxon and maybe also North Frisian. Both are minority/regional languages in Northern Germany and for Low Saxon also in the Eastern Netherlands.

Both, Low Saxon and North Frisian have no ISO 639-1 two letter code, but ISO 639-2 and ISO 639-3 three letter codes. Those are "nds" for Low Saxon and "frr" for North Frisian.

Why don't you allow 3 letter codes to be entered?

In the plugin's language settings I can enter a three letter code for the property "Locale at front-end", but for the property "Language code" I have to make up some not existing two letter codes for these languages like "nd" or "ns" for Low Saxon.

Any thought's on this?
@herrvigg
Copy link
Collaborator

Yes the 2-letter limitation is definitely becoming problematic. See #668 we should handle all those cases within the same improvement as a new feature. Good you pointed out that case with 3 letters.

@herrvigg herrvigg added the enhancement New feature or request label May 23, 2020
@herrvigg herrvigg mentioned this issue May 23, 2020
Open
@herrvigg
Copy link
Collaborator

We have to take it together with #668 so we can close this ticket.

herrvigg added a commit that referenced this issue Sep 13, 2020
@herrvigg
Extend language code format (#880)
43d532d 
Fixes #836.  Fixes partially #668.
Major refactoring: language code format now handled with a unique regex.
The new format allows 2 or 3-letter (ISO 639-2 and 639-3), lower case.
Upper case values are only allowed for legacy codes but not for new entries.
A migration of DB will be required before enforcing to lower case.
URL checks remain case-insensitive (unchanged).
@herrvigg
Copy link
Collaborator

Now merged in master for the 3-letter support!

herrvigg added a commit that referenced this issue Sep 13, 2020
@herrvigg
Extend language code to 3-letter ISO 639-2 (#880)
99aa7e2 
Fixes #836.  Fixes partially #668.
Major refactoring: language code format now handled with a unique regex.
The new format allows 2 or 3-letter (ISO 639-2 and 639-3), lower case.
Upper case values are only allowed for legacy codes but not for new entries.
A migration of DB will be required before enforcing to lower case.
URL checks remain case-insensitive (unchanged).
@herrvigg herrvigg mentioned this issue Sep 13, 2020
Open
@herrvigg
Copy link
Collaborator

@mikoet released in 3.9.0. Let me know how it works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@herrvigg @mikoet