Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Secure to "SameSite" attribute #976

Closed
sean-pk-mcgrath opened this issue Mar 1, 2021 · 2 comments
Closed

Add Secure to "SameSite" attribute #976

sean-pk-mcgrath opened this issue Mar 1, 2021 · 2 comments
Labels
core Core functionalities, including the admin section

Comments

@sean-pk-mcgrath
Copy link

I have the following warning on my browser (in newer browsers it should already be an error):

Cookie “qtrans_front_language” will be soon rejected because it has the “SameSite” attribute set to “None” or an invalid value, without the “secure” attribute. To know more about the “SameSite“ attribute, read https://developer.mozilla.org/docs/Web/HTTP/Headers/Set-Cookie/SameSite

The fix, according to the site, is:

To fix this, you will have to add the Secure attribute to your SameSite=None cookies.

Set-Cookie: flavor=choco; SameSite=None; Secure

@herrvigg
Copy link
Collaborator

herrvigg commented Mar 1, 2021

I didn't know about the "SameSite" attribute but the Secure attribute is already handled:
Advanced options / Make qTranslate‑XT cookies available only through HTTPS connections.

This was handled for the front cookie long ago. For the admin cookie it was fixed in 3.7.0 with #467.

@sean-pk-mcgrath
Copy link
Author

Thanks for the quick reply, herrvigg. You are correct: enabling that option eliminated the error message.

I missed the reply in https://github.com/qtranslate/qtranslate-xt/issues/644

@herrvigg herrvigg added the core Core functionalities, including the admin section label Aug 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core functionalities, including the admin section
Projects
None yet
Development

No branches or pull requests

2 participants