Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undefined text variable in JS admin #995

Closed
SarcasticSaint opened this issue Apr 6, 2021 · 2 comments
Closed

Undefined text variable in JS admin #995

SarcasticSaint opened this issue Apr 6, 2021 · 2 comments
Labels
bug Something isn't working, reproducible core Core functionalities, including the admin section

Comments

@SarcasticSaint
Copy link

SarcasticSaint commented Apr 6, 2021 •
edited
Loading

When im switching language, i have content from maing language and error in console"

Uncaught ReferenceError: text is not defined
at y (main.js?ver=3.10.0.dev.0:formatted:381)
at t. (main.js?ver=3.10.0.dev.0:formatted:807)
at t.switchActiveLanguage (main.js?ver=3.10.0.dev.0:formatted:638)
at HTMLLIElement.clickSwitchLanguage (main.js?ver=3.10.0.dev.0:formatted:649)

in main.js its here
text = e.contentField.value,
error1
error2

Problem in LSB mode, in Single Language Mode everything ok
herrvigg added a commit that referenced this issue Apr 6, 2021
@herrvigg
Fix text variable not defined (#995)
e944652
@herrvigg herrvigg added bug Something isn't working, reproducible core Core functionalities, including the admin section labels Apr 6, 2021
@herrvigg
Copy link
Collaborator

herrvigg commented Apr 6, 2021

Great you are testing on master :)
Strange this error didn't trigger in my case... there must be something with the strict mode. But I just pushed a patch now, should be fixed.

@herrvigg herrvigg changed the title Wrong content admin page Undefined text variable in JS admin Apr 6, 2021
@SarcasticSaint
Copy link
Author

Stable builds are boring xD
Yes, your fix working for me.
Thanks

qwave added a commit to qwave/qtranslate-xt that referenced this issue Apr 14, 2021
@qwave @herrvigg @zenideas
Plugin update (#1)
aa06f72 
* [Yoast] Add front filters schema and breadcumbs (qtranslate#947)

* Add Bangla localization files (qtranslate#960)

* Fix async events with jQuery3 (qtranslate#946)

* Anticipate qtx init before TinyMCEinit (qtranslate#946)

* Fix deprecated tinymce.editors (qtranslate#946)

* Remove ready handler from common (qtranslate#946)

With jQuery3, ready and load can be fired asynchronously.
We cannot assume ready is fired before load.
Since qtx is also initialized in load, no need for ready anymore.

* Refactor TinyMCE hook functions in common (qtranslate#978)

* Add permalink info for pre-path mode (qtranslate#821)

* Release 3.9.3

* Fix async qtx loading in ACF (qtranslate#988)

* Bundle Javascript with Webpack and Babel (qtranslate#990)

See instructions in the Pull Request.
Reactivate plugin or save settings to update the new paths in admin config.

* Minor webpack cleanup

* Bundle ACF with Webpack (qtranslate#992)

Regroup all sources into a single bundle dist/modules/acf.js.
Move and rename source files.

* Split common.js and rename to main (qtranslate#994)

* Split common.js into multiple core source files
* Rename common.js to main.js (entry and output)
* Rename qtranslate-admin-common PHP to qtranslate-admin-main
* qTranslateX class definition no longer exposed

* Refactor js var with ES6 const and let (qtranslate#996)

* Fix text variable not defined (qtranslate#995)

* Refactor ACF js with ES6 const let (qtranslate#997)

* Refactor jQuery wrappers with local alias (qtranslate#998)

* Disambiguate and rename js variables (qtranslate#1001)

* Define js constants for URL mode

* Remove unused js functions

* Minor js cleanup

* Complete js vars renaming

* Update dist js

* Delete deprecated functions in 3.7.3

* Fix qtx and repeaterFieldRemove in ACF JS (qtranslate#1006)

* Fix undefined use_block_editor_for_post (qtranslate#1004)

Co-authored-by: HerrVigg <herrvigg@gmail.com>
Co-authored-by: Lenin <doctortomorrow@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working, reproducible core Core functionalities, including the admin section
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@herrvigg @SarcasticSaint