-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable language switch for text widget #1042
Conversation
Hi herrvigg, thanks again for this work, when can we expect this to be released? |
I was about to merge this but WP has released a new feature in WP 5.8 to manage the widgets... with Gutenberg. |
Released in 3.11.0. |
The text widget was broken since 2017 though the main issue was raised in 2018: #616.
It is a very complex feature to restore due to the way the widgets are updated in javascript with many dynamic behaviors and "internal" WP sync fields: https://make.wordpress.org/core/2017/05/23/addition-of-tinymce-to-the-text-widget/
There are several situations to handle:
This major rework of the text widget in qTranslate-XT requires several changes in the JS API with new functions exposed:
attachContentHook
attachEditorHook
(*)setupLanguageSwitch
(*)
attachEditorHook
is renamed fromsetEditorHooks
but normally third-party code should rather useloadAdditionalTinyMceHooks()
for standard TinyMCE hooks.