Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ACF module structure #1191

Merged
merged 11 commits into from
Jun 15, 2022
Merged

Refactor ACF module structure #1191

merged 11 commits into from
Jun 15, 2022

Conversation

herrvigg
Copy link
Collaborator

@herrvigg herrvigg commented Jun 15, 2022

Redesign the ACF module around two classes :

  • QTX_Module_Acf_Register: set up the derived fields (front and admin)
  • QTX_Module_Acf_Admin: handle the admin sections and settings, loaded conditionally (admin only)

Other changes:

  • Delete internal QTX_Module_Acf_Interface
  • Remove all references to "plugin" instance
  • Module entry point handles only the main init() (for plugin and theme as before)
  • Rename all derived fields with QTX_Module_Acf_Field prefix
  • Comment dead code (already unused in legacy plugin), to be sorted out.

All changes are supposed to preserve all the current functionalities.

@herrvigg herrvigg added the module: ACF Integration with ACF label Jun 15, 2022
@herrvigg herrvigg merged commit 3a2a914 into master Jun 15, 2022
@herrvigg herrvigg deleted the acf-refactor-struct branch June 15, 2022 22:06
@herrvigg herrvigg mentioned this pull request Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: ACF Integration with ACF
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant