Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Internet Explorer #1313

Merged
merged 1 commit into from
Apr 7, 2023
Merged

Drop support for Internet Explorer #1313

merged 1 commit into from
Apr 7, 2023

Conversation

herrvigg
Copy link
Collaborator

@herrvigg herrvigg commented Apr 7, 2023

WordPress abandoned the support of IE with WP5.8 in July 2021.
https://wordpress.org/news/2021/05/dropping-support-for-internet-explorer-11/

Though we don't require that version of WP, it's time to abandon that legacy. See also this very old ticket: #32.

  1. Remove workaround for RegExp:@@split
    See also https://caniuse.com/mdn-javascript_builtins_regexp_--split

2) Update our browserslist for JS to be synced with WordPress
https://github.com/WordPress/wordpress-develop/blob/trunk/package.json

  1. Add more debug info about browser in the troubleshooting section.

WordPress abandoned the support of IE with WP5.8 in July 2021.
https://wordpress.org/news/2021/05/dropping-support-for-internet-explorer-11/

Though we don't require that version of WP, it's time to abandon
that legacy. See also this very old ticket: #32.

1) Remove workaround for `RegExp:@@split`
See also https://caniuse.com/mdn-javascript_builtins_regexp_--split

2) Update our `browserslist` for JS to be synced with WordPress
https://github.com/WordPress/wordpress-develop/blob/trunk/package.json

3) Add more debug info about browser in the troubleshooting section.
@herrvigg herrvigg added the core Core functionalities, including the admin section label Apr 7, 2023
@herrvigg herrvigg merged commit c8622cc into master Apr 7, 2023
@herrvigg herrvigg deleted the drop-ie branch April 7, 2023 10:47
@herrvigg
Copy link
Collaborator Author

herrvigg commented Apr 7, 2023

The change on the browserlists makes the JS code more compact and more modern e.g. with const (it was about time...).
I hope this won't break some old user configs but it is consistent with WP developer configuration that appeared in WP5.8.
Perhaps it's clearer if I make this as the required WP version though we don't need it strictly.

herrvigg added a commit that referenced this pull request Apr 7, 2023
The new browserslists may break some old configurations beside IE.
We'll take it in a separate patch, maybe for next major release.
@herrvigg
Copy link
Collaborator Author

herrvigg commented Apr 7, 2023

I reverted the change on the new browserlist, it may break some old configurations beside IE.
We'll take it in a separate patch, maybe for next major release.

herrvigg added a commit that referenced this pull request Apr 7, 2023
WordPress abandoned the support of IE with WP5.8 in July 2021.
https://wordpress.org/news/2021/05/dropping-support-for-internet-explorer-11/

Though we don't require that version of WP, it's time to abandon
that legacy. See also this very old ticket: #32.

1) Remove workaround for `RegExp:@@split`
See also https://caniuse.com/mdn-javascript_builtins_regexp_--split

2) Add more debug info about browser in the troubleshooting section.
herrvigg added a commit that referenced this pull request Apr 7, 2023
WordPress abandoned the support of IE with WP5.8 in July 2021.
https://wordpress.org/news/2021/05/dropping-support-for-internet-explorer-11/

Though we don't require that version of WP, it's time to abandon
that legacy. See also this very old ticket: #32.

1) Remove workaround for `RegExp:@@split`
See also https://caniuse.com/mdn-javascript_builtins_regexp_--split

2) Add more debug info about browser in the troubleshooting section.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core functionalities, including the admin section
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant