Qt-downloader latest with gha testing #1038
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like GitHub disabled set-env and add-path commands, see https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/. Workflow file needs to be changed according to that instruction. |
|
Sure. Will look into it |
RAJAGOPALAN-GANGADHARAN
force-pushed
the
qtd-update
branch
2 times, most recently
from
23351e3
to
f48fec6
Compare
RAJAGOPALAN-GANGADHARAN
force-pushed
the
qtd-update
branch
from
f48fec6
to
cd2c844
Compare
annulen
reviewed
Dec 18, 2020
| echo "$GITHUB_WORKSPACE" >> $GITHUB_PATH | ||
| echo "CCACHE_BASEDIR=$GITHUB_WORKSPACE" >> $GITHUB_ENV | ||
| echo "CCACHE_DIR=$GITHUB_WORKSPACE/.ccache" >> $GITHUB_ENV | ||
| echo "cmake_args=-DCMAKE_C_COMPILER_LAUNCHER=ccache " \ |
There was a problem hiding this comment.
Does resulting cmake_args contain -DCMAKE_CXX_COMPILER_LAUNCHER=ccache and -DENABLE_PCH=OFF? Unescaped spaces make me feel uneasy.
There was a problem hiding this comment.
https://github.com/qtwebkit/qtwebkit/pull/1038/checks?check_run_id=1545151212#step:13:19
The env variable is rightly set, check put ubuntu for e.g.
|
Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.