Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for RISC-V 64-bit architecture #982

Merged
merged 1 commit into from Jun 4, 2020
Merged

Add support for RISC-V 64-bit architecture #982

merged 1 commit into from Jun 4, 2020

Conversation

mitya57
Copy link

@mitya57 mitya57 commented Apr 14, 2020

This is based on Ubuntu's patch by William Grant, that was added in https://launchpad.net/ubuntu/+source/qtwebkit-opensource-src/5.212.0~alpha4-1ubuntu1.

The most controversial change here is adding the THREADS_PREFER_PTHREAD_FLAG. But I can make it conditional or drop it completely if you want.

@mitya57
Copy link
Author

mitya57 commented Apr 14, 2020 

JavaScriptCore.lib(JITOperations.cpp.obj) : error LNK2019: unresolved external symbol getHostCallReturnValue referenced in function handleHostCall

JavaScriptCore.lib(LLIntSlowPaths.cpp.obj) : error LNK2001: unresolved external symbol getHostCallReturnValue

bin\jsc.exe : fatal error LNK1120: 1 unresolved externals

This is unrelated to my changes, right?

@annulen
Copy link
Member

annulen commented Apr 15, 2020 •
edited

The most controversial change here is adding the THREADS_PREFER_PTHREAD_FLAG

It was considered by upstream (see https://bugs.webkit.org/show_bug.cgi?id=182622) but reverted because it caused issues in other cases

This is unrelated to my changes, right?

It is directly caused by them, though easy to fix

Anyway I would prefer if such patch was merged to upstream first.

@annulen
Copy link
Member

annulen commented Apr 15, 2020

Note that you can pass THREADS_PREFER_PTHREAD_FLAG via cmake arguments (like -DTHREADS_PREFER_PTHREAD_FLAG=ON)

@mitya57
Copy link
Author

mitya57 commented Apr 16, 2020 •
edited

Hi @annulen!

With upstream master, this patch is not needed, presumably because of 861472b (and dtoa support was added in ca0d631). The only needed change is THREADS_PREFER_PTHREAD_FLAG, but as you say, one may set it on the command line.

I will wait for the CI to pass and then retarget to webkit-stable.

@annulen
Copy link
Member

annulen commented Apr 16, 2020

OK. Since this patch is not needed in qtwebkit-dev (which has aforementioned patches), it should go to qtwebkit-5.212, not qtwebkit-stable.

@mitya57
Copy link
Author

mitya57 commented Apr 16, 2020

That's where it is directed now, I just got confused by the message from Travis.

@annulen annulen merged commit d9824ec into qtwebkit:qtwebkit-5.212 Jun 4, 2020
raspbian-autopush pushed a commit to raspbian-packages/qtwebkit-opensource-src that referenced this pull request Jul 3, 2020
@wgrant @mitya57
add support for riscv64 architecture
f35319e 
Forwarded: qtwebkit/qtwebkit#982
Last-Update: 2020-04-28


Gbp-Pq: Name support_riscv64.diff
raspbian-autopush pushed a commit to raspbian-packages/qtwebkit-opensource-src that referenced this pull request Aug 12, 2020
@wgrant @mitya57
add support for riscv64 architecture
bba59d8 
Forwarded: qtwebkit/qtwebkit#982
Last-Update: 2020-04-28


Gbp-Pq: Name support_riscv64.diff
raspbian-autopush pushed a commit to raspbian-packages/qtwebkit-opensource-src that referenced this pull request Nov 6, 2020
@wgrant @mitya57
add support for riscv64 architecture
62013ad 
Forwarded: qtwebkit/qtwebkit#982
Last-Update: 2020-04-28


Gbp-Pq: Name support_riscv64.diff
raspbian-autopush pushed a commit to raspbian-packages/qtwebkit-opensource-src that referenced this pull request Dec 18, 2020
@wgrant @mitya57
add support for riscv64 architecture
16b8de1 
Forwarded: qtwebkit/qtwebkit#982
Last-Update: 2020-04-28


Gbp-Pq: Name support_riscv64.diff
raspbian-autopush pushed a commit to raspbian-packages/qtwebkit-opensource-src that referenced this pull request Jan 11, 2021
@wgrant @mitya57
add support for riscv64 architecture
fbc3ae9 
Forwarded: qtwebkit/qtwebkit#982
Last-Update: 2020-04-28


Gbp-Pq: Name support_riscv64.diff
raspbian-autopush pushed a commit to raspbian-packages/qtwebkit-opensource-src that referenced this pull request Sep 5, 2021
@wgrant @mitya57
add support for riscv64 architecture
c4d2d0b 
Forwarded: qtwebkit/qtwebkit#982
Last-Update: 2020-04-28


Gbp-Pq: Name support_riscv64.diff
IEAST added a commit to IEAST/archriscv-packages that referenced this pull request Nov 16, 2021
@IEAST
addpkg: qt5-webkit
d14659c 
Reference qtwebkit/qtwebkit#982 ,set `-DTHREADS_PREFER_PTHREAD_FLAG=ON`.
Since
```
/build/qt5-webkit/src/qtwebkit-5.212.0-alpha4/Source/JavaScriptCore/assembler/MacroAssembler.h:64:2: error: #error "The MacroAssembler is not supported on this platform."
    64 | #error "The MacroAssembler is not supported on this platform."

```
so set `-DENABLE_JIT=OFF`
@IEAST IEAST mentioned this pull request Nov 16, 2021
Merged
felixonmars pushed a commit to felixonmars/archriscv-packages that referenced this pull request Nov 23, 2021
@IEAST @felixonmars
addpkg: qt5-webkit
ca7e602 
Reference qtwebkit/qtwebkit#982 ,set `-DTHREADS_PREFER_PTHREAD_FLAG=ON`.
Since
```
/build/qt5-webkit/src/qtwebkit-5.212.0-alpha4/Source/JavaScriptCore/assembler/MacroAssembler.h:64:2: error: #error "The MacroAssembler is not supported on this platform."
    64 | #error "The MacroAssembler is not supported on this platform."

```
so set `-DENABLE_JIT=OFF`
raspbian-autopush pushed a commit to raspbian-packages/qtwebkit-opensource-src that referenced this pull request Nov 30, 2021
@wgrant @mitya57
add support for riscv64 architecture
aa555f7 
Forwarded: qtwebkit/qtwebkit#982
Last-Update: 2020-04-28


Gbp-Pq: Name support_riscv64.diff
raspbian-autopush pushed a commit to raspbian-packages/qtwebkit-opensource-src that referenced this pull request Apr 28, 2022
@wgrant @mitya57
add support for riscv64 architecture
1b80c71 
Forwarded: qtwebkit/qtwebkit#982
Last-Update: 2020-04-28


Gbp-Pq: Name support_riscv64.diff
raspbian-autopush pushed a commit to raspbian-packages/qtwebkit-opensource-src that referenced this pull request Jun 22, 2022
@wgrant @mitya57
add support for riscv64 architecture
9440f05 
Forwarded: qtwebkit/qtwebkit#982
Last-Update: 2020-04-28


Gbp-Pq: Name support_riscv64.diff
raspbian-autopush pushed a commit to raspbian-packages/qtwebkit-opensource-src that referenced this pull request Aug 5, 2022
@wgrant @mitya57
add support for riscv64 architecture
57a7094 
Forwarded: qtwebkit/qtwebkit#982
Last-Update: 2020-04-28


Gbp-Pq: Name support_riscv64.diff
raspbian-autopush pushed a commit to raspbian-packages/qtwebkit-opensource-src that referenced this pull request Oct 30, 2022
@wgrant @mitya57
add support for riscv64 architecture
4dfd207 
Forwarded: qtwebkit/qtwebkit#982
Last-Update: 2020-04-28


Gbp-Pq: Name support_riscv64.diff
raspbian-autopush pushed a commit to raspbian-packages/qtwebkit-opensource-src that referenced this pull request Nov 8, 2022
@wgrant @mitya57
add support for riscv64 architecture
8faaafd 
Forwarded: qtwebkit/qtwebkit#982
Last-Update: 2020-04-28


Gbp-Pq: Name support_riscv64.diff
raspbian-autopush pushed a commit to raspbian-packages/qtwebkit-opensource-src that referenced this pull request Dec 31, 2022
@wgrant @mitya57
add support for riscv64 architecture
6096f3a 
Forwarded: qtwebkit/qtwebkit#982
Last-Update: 2020-04-28


Gbp-Pq: Name support_riscv64.diff
raspbian-autopush pushed a commit to raspbian-packages/qtwebkit-opensource-src that referenced this pull request Jan 21, 2023
@wgrant @mitya57
add support for riscv64 architecture
9f36b43 
Forwarded: qtwebkit/qtwebkit#982
Last-Update: 2020-04-28


Gbp-Pq: Name support_riscv64.diff
raspbian-autopush pushed a commit to raspbian-packages/qtwebkit-opensource-src that referenced this pull request Sep 14, 2023
@wgrant @mitya57
add support for riscv64 architecture
2411f3a 
Forwarded: qtwebkit/qtwebkit#982
Last-Update: 2020-04-28


Gbp-Pq: Name support_riscv64.diff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annulen annulen annulen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mitya57 @annulen