Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support matplotlib #1194

Closed
wants to merge 3 commits into from
Closed

Support matplotlib #1194

wants to merge 3 commits into from

Conversation

Asaaj
Copy link
Contributor

@Asaaj Asaaj commented Mar 18, 2024

Copy link

vercel bot commented Mar 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quadratic ✅ Ready (Inspect) Visit Preview Mar 18, 2024 8:29pm

@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1194 March 18, 2024 20:23 Inactive
Comment on lines +31 to +33
def __init__(self, *args, **kwargs):
super().__init__(*args, **kwargs)
print("CREATED")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still an issue that multiple runs of a matplotlib cell cause an assertion failure, as it thinks we're trying to return multiple figures from one cell. I haven't tracked this down yet

@davidkircos
Copy link
Collaborator

matplotlib via pyodide doesn't support png yet, so this can't be used yet

@davidkircos
Copy link
Collaborator

Apparently it does work now, reopening

@davidkircos davidkircos reopened this Jun 19, 2024
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1194 June 19, 2024 18:09 Inactive
@davidfig davidfig mentioned this pull request Jul 22, 2024
2 tasks
@davidkircos
Copy link
Collaborator

Outdated, closing for now. Linked in related issue #1654 to revive when prioritized.

@davidkircos davidkircos closed this Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants