feat: color picker style enhancements #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jimniels
commented
Feb 8, 2023
•
jimniels
commented
- Get rid of box-shadows inside color picker menus
- Refines swatch styles
- Adds a "clear" button that appears more incorporated to the picker
- Works everywhere the color picker works (in both Floating Context menu and TopBar Formatting Menu)
- Fill color
- Text color
jimniels
commented
Feb 8, 2023
jimniels
commented
Feb 8, 2023
jimniels
commented
Feb 8, 2023
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
jimniels
commented
Feb 8, 2023
| right: 0; | ||
| top: 0; | ||
| bottom: 0; | ||
| } |
There was a problem hiding this comment.
I don't love everything in this CSS overrides file, but react-color doesn't have a lot of great extensibility for styling other than overriding like this.
There was a problem hiding this comment.
I don't love it either, but it works.
I am weird and like inline styles, because they are always easy to find. In React, if you want reusable styles - make a component with inline styles. :)
Also in TS styles are type-checked
davidkircos
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.