Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove icons from UI #826

Closed
wants to merge 4 commits into from
Closed

Conversation

jimniels
Copy link
Collaborator

@jimniels jimniels commented Nov 16, 2023

IMO we have too many icons. It's diluting the value/efficacy of the ones we do have. I think we should use them a lot more sparingly. My impulse is to remove a bunch, and then we can always add them back where we can justify their value.

The new command palette

CleanShot 2023-11-16 at 16 31 28@2x

which is a lot more akin to Figma's: graphical elements are only used for 1) toggles, to indicate the on/off state of an item, or 2) external links, indicating these items will take you out of the app.

(Figma's UI)

CleanShot 2023-11-16 at 16 28 28@2x

I also removed them from dropdown menus

CleanShot 2023-11-16 at 20 34 34@2x

CleanShot 2023-11-16 at 20 35 44@2x

For now, I think it's ok to keep them in the formatting menu.

Todos

Copy link

vercel bot commented Nov 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quadratic ✅ Ready (Inspect) Visit Preview Nov 17, 2023 5:50pm

@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-826 November 16, 2023 23:34 Inactive
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bdf6e23) 82.76% compared to head (2ed5fcd) 82.76%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #826   +/-   ##
=======================================
  Coverage   82.76%   82.76%           
=======================================
  Files         116      116           
  Lines       17339    17339           
=======================================
  Hits        14350    14350           
  Misses       2989     2989           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from file-list-controls to main November 16, 2023 23:36
@ddimaria
Copy link
Collaborator

You've been cursed by the single commit "feature" in Heroku

@jimniels jimniels temporarily deployed to quadratic-api-dev-pr-826 November 17, 2023 17:39 Inactive
@jimniels jimniels temporarily deployed to quadratic-api-dev-pr-826 November 17, 2023 17:40 Inactive
@davidkircos
Copy link
Collaborator

For me it's easier to skim for symbols than it is to read each item. Esp for formatting items icons make a lot of sense to me.

Why do you want to remove them?

@davidkircos davidkircos marked this pull request as draft November 20, 2023 18:01
@jimniels
Copy link
Collaborator Author

jimniels commented Dec 4, 2023

This is going to be superceeded by the work in #840

@jimniels jimniels closed this Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants