-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove icons from UI #826
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #826 +/- ##
=======================================
Coverage 82.76% 82.76%
=======================================
Files 116 116
Lines 17339 17339
=======================================
Hits 14350 14350
Misses 2989 2989 ☔ View full report in Codecov by Sentry. |
You've been cursed by the single commit "feature" in Heroku |
For me it's easier to skim for symbols than it is to read each item. Esp for formatting items icons make a lot of sense to me. Why do you want to remove them? |
This is going to be superceeded by the work in #840 |
IMO we have too many icons. It's diluting the value/efficacy of the ones we do have. I think we should use them a lot more sparingly. My impulse is to remove a bunch, and then we can always add them back where we can justify their value.
The new command palette
which is a lot more akin to Figma's: graphical elements are only used for 1) toggles, to indicate the on/off state of an item, or 2) external links, indicating these items will take you out of the app.
(Figma's UI)
I also removed them from dropdown menus
For now, I think it's ok to keep them in the formatting menu.
Todos