Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement a command palette that uses components from shadcn/ui #840

Merged
merged 26 commits into from
Mar 12, 2024

Conversation

jimniels
Copy link
Collaborator

@jimniels jimniels commented Nov 17, 2023

CleanShot 2024-03-11 at 16 47 22@2x

CleanShot 2024-03-11 at 16 47 49@2x

Notes

  • When you filter to an item that's at the bottom of the list, then clear your query, the scroll position in the list doesn't reset. This seems to be a feature-and-or-bug with the cmdk lib itself. I filed an issue and we can track it there. Shouldn't stop us from shipping this as-is IMO.

Copy link

vercel bot commented Nov 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quadratic ✅ Ready (Inspect) Visit Preview Mar 12, 2024 0:36am

@jimniels jimniels changed the base branch from main to command-pallete-icons November 17, 2023 17:33
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-840 November 17, 2023 17:33 Inactive
@jimniels jimniels marked this pull request as draft November 17, 2023 17:33
@jimniels jimniels temporarily deployed to quadratic-api-dev-pr-840 November 23, 2023 05:58 Inactive
@jimniels jimniels changed the base branch from command-pallete-icons to main November 23, 2023 05:58
@jimniels jimniels temporarily deployed to quadratic-api-dev-pr-840 November 23, 2023 06:07 Inactive
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.12%. Comparing base (6fd7952) to head (686a858).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #840   +/-   ##
=======================================
  Coverage   89.12%   89.12%           
=======================================
  Files         155      155           
  Lines       25375    25375           
=======================================
  Hits        22615    22615           
  Misses       2760     2760           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jimniels jimniels temporarily deployed to quadratic-api-dev-pr-840 November 25, 2023 05:22 Inactive
@jimniels jimniels mentioned this pull request Dec 4, 2023
1 task
@jimniels
Copy link
Collaborator Author

jimniels commented Mar 6, 2024

Closing this. Will have to revisit later.

@jimniels jimniels closed this Mar 6, 2024
@jimniels jimniels reopened this Mar 7, 2024
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-840 March 7, 2024 18:01 Inactive
@jimniels jimniels temporarily deployed to quadratic-api-dev-pr-840 March 11, 2024 16:57 Inactive
@jimniels jimniels marked this pull request as ready for review March 11, 2024 17:27
@jimniels jimniels temporarily deployed to quadratic-api-dev-pr-840 March 11, 2024 21:49 Inactive
@jimniels jimniels temporarily deployed to quadratic-api-dev-pr-840 March 12, 2024 00:30 Inactive
@davidkircos davidkircos merged commit 4d969e1 into main Mar 12, 2024
11 of 12 checks passed
@davidkircos davidkircos deleted the command-palette-shadcn branch March 12, 2024 00:58
@jimniels jimniels mentioned this pull request Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants