Use ember-cli project nodeModulesPath when available
#31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
@quaertym I know the powers that be are swinging for an ember-cli release this week. I'd love to see this go with it if you have the time to review. |
|
It looks great, thanks! 🍺 |
quaertym
added a commit
that referenced
this pull request
May 12, 2015
Use ember-cli project `nodeModulesPath` when available
|
Awwww sweet :-) Are you going to roll a release as well? You are about to make my week. |
|
Yep, it is coming. 👍 |
|
😍 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up PR as mentioned in PR 26.
ember-cli/ember-cli#3771 has added a
nodeModulesPathproperty to the ember-cli project. This PR detects and uses that property if it is available, which will allowember-cli-dependency-checkerto function properly for ember-cli projects that have anode_modulesdirectory outside of the project root.This also adds a
projectBuildertest helper to unify the set up of a sample project in tests.