Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up Circle CI #5

Closed
wants to merge 2 commits into from
Closed

Set up Circle CI #5

wants to merge 2 commits into from

Conversation

kazk
Copy link
Member

@kazk kazk commented Oct 12, 2019

No description provided.

@ghost
Copy link

ghost commented Oct 12, 2019 •
edited by ghost
Loading

DeepCode Report (#2cad1e)

DeepCode analyzed this pull request.
There are no new issues.

@kazk
Copy link
Member Author

kazk commented Oct 12, 2019

Tests are failing with Rails 5 because the test model includes both ActiveModel::Dirty and ActiveModel::Serialization when these two have conflicting requirements in this version.

https://github.com/jhoffner/mag-lev/blob/8b2cab2016401910f5dcec604810252253195a8e/spec/support/models.rb#L4-L7

ActiveModel::Serialization requires attributes hash to be defined. changes_applied from ActiveModel::Dirty doesn't work when attributes is a Hash (needs ActiveModel::AttributeSet because it does @attributes.map(&:forgetting_assignment)).

@kazk kazk closed this Jan 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@kazk