This repository has been archived by the owner on Dec 31, 2022. It is now read-only.
Fixed literal Permission Problem in PackageManager #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Would you mind adding a comment clarifying that 438 == 644 in octal? |
|
Yes, I just commited the comment. But note that 438 translates to 666 octal (Which translates to Read/Write Permission) |
qmfrederik
reviewed
Sep 22, 2020
qmfrederik
reviewed
Sep 22, 2020
|
Thanks! Two whitespace-related changes, and I'll merge this. You can commit the suggestion from the GitHub website. |
Co-authored-by: Frederik Carlier <frederik.carlier@quamotion.mobi>
Co-authored-by: Frederik Carlier <frederik.carlier@quamotion.mobi>
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #157, all credit goes to @dcrespo3d
Changed the literal "644" to "438". Now, APKs can be successfully installed on a device again.