Skip to content

Commit

Permalink
update for v4 release
Browse files Browse the repository at this point in the history
  • Loading branch information
Kenneth Benoit authored and Kenneth Benoit committed Apr 9, 2024
1 parent 5436f53 commit 0a49557
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 28 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ data](https://cdn.rawgit.com/quanteda/quanteda/master/images/quanteda_logo.svg)]

[![CRAN
Version](https://www.r-pkg.org/badges/version/quanteda)](https://CRAN.R-project.org/package=quanteda)
[![](https://img.shields.io/badge/devel%20version-4.0.0-royalblue.svg)](https://github.com/quanteda/quanteda)
[![](https://img.shields.io/badge/devel%20version-4.0.1-royalblue.svg)](https://github.com/quanteda/quanteda)
[![Downloads](https://cranlogs.r-pkg.org/badges/quanteda)](https://CRAN.R-project.org/package=quanteda)
[![Total
Downloads](https://cranlogs.r-pkg.org/badges/grand-total/quanteda?color=orange)](https://CRAN.R-project.org/package=quanteda)
Expand Down
28 changes: 4 additions & 24 deletions cran-comments.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,36 +2,16 @@

Fixed:

- Breaking documentation link in two .Rd files in the package **tosca**: fixed on the **quanteda** side.
- A failing test caused by the ever-shifting behaviour of **Matrix** and the devel R on r-devel-linux-x86_64-debian-clang and r-devel-linux-x86_64-debian-gcc.

- **RNewsflow** - Fised on CRAN, based on our PR (https://github.com/kasperwelbers/RNewsflow/pull/9).
- An Undeclared package ‘quanteda.textstats’ in Rd xrefs.

Informed and pending a fix:
- An installation failure on r-devel-linux-x86_64-fedora-gcc due to searching for TBB in all the wrong places.

- **tidytext**: We have not only informed the package maintainer that their use in a vignette of a function deprecated in v3 (released in 2021) is now defunct, but also we issued a PR to fix this (https://github.com/juliasilge/tidytext/pull/242).

- **gofastr**: That package calls functions that we first deprecated in version 3.3 and have now made defunct. We issued a pull request fixing this for that package nearly six months ago (https://github.com/trinker/gofastr/pull/12) and the package maintainer has yet to accept it.


# Submission notes

This is both a fix for issues noted on CRAN checks and a major update to the package. The major update is to bring new functionalities to quanteda, make the code more efficient, and rationalise the code through new deprecations and removals.

The fixes to existing CRAN issues include:

* We now compile the TBB library directly into the package for parallelism, rather than relying on RcppParallel. Relying on the the TBB implementation from that package led to complications with UBSAN and "Additional Issues" on some platforms that we could not fix within that framework.
* Fixes problems notified by CRAN concerning UseMethod no longer forwarding local variables from the generic.

Major changes include:

* A major update versus v.3.3.1, with many new features and improvements -- see NEWS.
* Numerous compatibility enhancements with newer versions of some packages (e.g. Matrix).
* Numerous bug fixes.

## Test environments

* local macOS 14.2.1, R 4.3.3
* Ubuntu 22.04 LTS, R 4.3.3
* local macOS 14.4.1, R 4.3.3
* Windows release via devtools::check_win_release()
* Windows devel via devtools::check_win_devel()
* Windows oldrelease via devtools::check_win_oldrelease()
Expand Down
7 changes: 4 additions & 3 deletions tests/testthat/test-fcm.R
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,10 @@ test_that("fcm works with dfm and tokens in the same way", {

# same as document context diagonal
fcmat_toks_win_ord <- fcm(toks, context = "window", window = 1000, ordered = TRUE)
fcmat_toks_win_ord
expect_equal(diag(as.matrix(fcmat_toks_doc)),
diag(as.matrix(fcmat_toks_win_ord)))
print(diag(as.matrix(fcmat_toks_doc)))
print(diag(as.matrix(fcmat_toks_win_ord)))
expect_equivalent(diag(as.matrix(fcmat_toks_doc)),
diag(as.matrix(fcmat_toks_win_ord)))
})

# Testing weighting function
Expand Down

0 comments on commit 0a49557

Please sign in to comment.