Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docvarsfrom only supports one source #9

Open
adamobeng opened this issue Nov 1, 2016 · 2 comments
Open

docvarsfrom only supports one source #9

adamobeng opened this issue Nov 1, 2016 · 2 comments
Assignees

Comments

@adamobeng
Copy link
Collaborator

@ken, you changed this behaviour. It used to be the case that you could get docvars from both filenames and metadata at the same time. How should it be?

@kbenoit
Copy link
Collaborator

kbenoit commented Nov 1, 2016

I thought it should be one or the other, in case they conflicted, but I can see that maybe you would have a .csv file and want to add even more docvars from the filename. Feel free to add back this behaviour if you wish. We will need to check for collisions though.

@pnulty has long championed the idea of adding dovcars automatically from directory elements of the path below the wildcard level, which I think is a great idea. I don't think we offer this at the moment though. New issue?

@pnulty
Copy link
Collaborator

pnulty commented Nov 1, 2016

Happy to take it on as an issue if not already supported

On 1 Nov 2016 13:18, "Kenneth Benoit" notifications@github.com wrote:

I thought it should be one or the other, in case they conflicted, but I
can see that maybe you would have a .csv file and want to add even more
docvars from the filename. Feel free to add back this behaviour if you
wish. We will need to check for collisions though.

@pnulty https://github.com/pnulty has long championed the idea of
adding dovcars automatically from directory elements of the path below the
wildcard level, which I think is a great idea. I don't think we offer this
at the moment though. New issue?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#9 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAn8zBiiQepm1KlHARBxVPgTxy334C2Uks5q5zw2gaJpZM4KmE-Z
.

@kbenoit kbenoit modified the milestone: CRAN release May 15, 2017
@adamobeng adamobeng removed this from the CRAN release milestone May 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants