Fixed numbers truthiness

quantified-uncertainty · Dec 4, 2023 · 3dd8044 · 3dd8044
1 parent 993eacd
commit 3dd8044
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/packages/squiggle-lang/__tests__/library/builtin_test.ts b/packages/squiggle-lang/__tests__/library/builtin_test.ts
@@ -55,4 +55,11 @@ describe("Operators", () => {
     testEvalToBe("typeOf(true)", '"Boolean"');
     testEvalToBe("typeOf({|f| f})", '"Function"');
   });
+  describe("not", () => {
+    testEvalToBe("not(3)", "false");
+    testEvalToBe("!!(3)", "true");
+    testEvalToBe("not(0)", "true");
+    testEvalToBe("!(0)", "true");
+    testEvalToBe("!(false)", "true");
+  });
 });
diff --git a/packages/squiggle-lang/src/fr/builtin.ts b/packages/squiggle-lang/src/fr/builtin.ts
@@ -39,7 +39,7 @@ export const library = [
     definitions: [
       makeDefinition([frNumber], ([x]) => {
         // unary prefix !
-        return vBool(x !== 0);
+        return vBool(x === 0);
       }),
       makeDefinition([frBool], ([x]) => {
         // unary prefix !