FrWithTags should work for 0

quantified-uncertainty · Jan 12, 2024 · 9c06bd7 · 9c06bd7
1 parent 53a91d0
commit 9c06bd7
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/.changeset/twenty-rocks-lie.md b/.changeset/twenty-rocks-lie.md
@@ -0,0 +1,5 @@
+---
+"@quri/squiggle-lang": patch
+---
+
+Bug fix: frWithTags should work for 0 value
diff --git a/packages/squiggle-lang/__tests__/library/tag_test.ts b/packages/squiggle-lang/__tests__/library/tag_test.ts
@@ -18,6 +18,7 @@ describe("Tags", () => {
 
   describe("format", () => {
     testEvalToBe("123 -> Tag.format('.2%') -> Tag.getFormat", '".2%"');
+    testEvalToBe("0 -> Tag.format('.2%') -> Tag.getFormat", '".2%"');
   });
 
   describe("notebook", () => {

diff --git a/packages/squiggle-lang/src/library/registry/frTypes.ts b/packages/squiggle-lang/src/library/registry/frTypes.ts
@@ -174,7 +174,7 @@ export const frWithTags = <T>(
     unpack: (v) => {
       const unpackedItem = itemType.unpack(v);
       return (
-        (unpackedItem && {
+        (unpackedItem !== undefined && {
           value: unpackedItem,
           tags: v.tags ?? new ValueTags({}),
         }) ||