Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lang: add % number suffix #2239

Merged
merged 3 commits into from Aug 28, 2023
Merged

lang: add % number suffix #2239

merged 3 commits into from Aug 28, 2023

Conversation

cab404
Copy link
Collaborator

@cab404 cab404 commented Aug 26, 2023

Fixes #1605

@changeset-bot
Copy link

changeset-bot bot commented Aug 26, 2023

🦋 Changeset detected

Latest commit: 4e94f13

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@quri/squiggle-lang Minor
@quri/squiggle-components Minor
@quri/prettier-plugin-squiggle Patch
vscode-squiggle Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cab404 cab404 temporarily deployed to Preview August 26, 2023 02:54 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented Aug 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
quri-hub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 26, 2023 3:02am
squiggle-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 26, 2023 3:02am
squiggle-website ✅ Ready (Inspect) Visit Preview Aug 26, 2023 3:02am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
quri-ui ⬜️ Ignored (Inspect) Visit Preview Aug 26, 2023 3:02am

@codecov
Copy link

codecov bot commented Aug 26, 2023

Codecov Report

Merging #2239 (896c221) into main (f0042af) will increase coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

❗ Current head 896c221 differs from pull request most recent head 4e94f13. Consider uploading reports for the commit 4e94f13 to get more accurate results

@@            Coverage Diff             @@
##             main    #2239      +/-   ##
==========================================
+ Coverage   73.04%   73.06%   +0.01%     
==========================================
  Files         107      107              
  Lines        5349     5349              
  Branches     1026     1026              
==========================================
+ Hits         3907     3908       +1     
+ Misses       1434     1433       -1     
  Partials        8        8              

see 1 file with indirect coverage changes

@@ -44,6 +44,11 @@ describe("Peggy parse", () => {
testParse("100e-2-5", "(Program (InfixCall - 100e-2 5))");
});

describe("units", () => {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not exactly a parse test though~

Copy link
Collaborator

@berekuk berekuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@berekuk berekuk merged commit 723ee71 into main Aug 28, 2023
8 checks passed
@berekuk berekuk deleted the cab/percents branch August 28, 2023 23:44
@OAGr
Copy link
Contributor

OAGr commented Aug 28, 2023

Great, I look forward to using this!

@github-actions github-actions bot mentioned this pull request Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Implement % unit
3 participants