Fix combinePointwise precision on discrete pointsets

[berekuk]

Fixes #2336.

[changeset-bot]

🦋 Changeset detected

Latest commit: d4dbda3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages

Name	Type
@quri/squiggle-lang	Patch
@quri/squiggle-components	Patch
@quri/prettier-plugin-squiggle	Patch
vscode-squiggle	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Ignored Deployments

Name	Status	Preview	Updated (UTC)
quri-hub	⬜️ Ignored (Inspect)	Visit Preview	Nov 9, 2023 9:55pm
quri-ui	⬜️ Ignored (Inspect)	Visit Preview	Nov 9, 2023 9:55pm
squiggle-components	⬜️ Ignored (Inspect)	Visit Preview	Nov 9, 2023 9:55pm
squiggle-website	⬜️ Ignored (Inspect)	Visit Preview	Nov 9, 2023 9:55pm

[sweep-ai]

Apply Sweep Rules to your PR?

• Apply: All docstrings and comments should be up to date.
• Apply: Ensure that all variables and functions have descriptive names.
• Apply: Avoid using unnecessary separators or extra characters in code.
• Apply: Use consistent indentation and spacing throughout the code.
• Apply: Ensure that all code is properly formatted and follows the style guide.
• Apply: Avoid using magic numbers or hard-coded values in the code.

[berekuk]

So... webpack is failing, and I have no idea why. It doesn't fail for me on localhost. Might be different node versions or a bug in turborepo caches.

Tbh this makes me want to remove webpack; we've been shipping components bundle on NPM, but that's not a common practice, usually package consumers do that themselves. Webpack bundle was useful for Observable, but:

• it's possible to do a bundle separately
• we probably want to switch to rollup, because we already use Vite for Storybook
• we haven't supported Observable since 0.6.0 and it's low priority
• also webpack is slow

One useful thing with webpack that I used occasionally was webpack-bundle-analyzer, but rollup-plugin-visualizer can replace it.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c25e69e) 71.55% compared to head (e5c78d4) 71.74%.
Report is 18 commits behind head on main.

❗ Current head e5c78d4 differs from pull request most recent head d4dbda3. Consider uploading reports for the commit d4dbda3 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2514      +/-   ##
==========================================
+ Coverage   71.55%   71.74%   +0.18%     
==========================================
  Files         113      113              
  Lines        5927     5952      +25     
  Branches     1179     1182       +3     
==========================================
+ Hits         4241     4270      +29     
+ Misses       1678     1674       -4     
  Partials        8        8              

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[OAGr]

why the change?

[berekuk]

It's just a coding style change, I usually don't do this unless I want to do other changes, but here I thought I'll make them and then forgot about it.

From https://github.com/quantified-uncertainty/squiggle/blob/main/CONTRIBUTING.md:

Prefer function keyword over arrow functions in top scope, use arrow functions otherwise

(trivial to do in VS Code, btw, Cmd+. -> "Convert to named function".)

[OAGr]

I'm still seeing the bug? Also, build needs to pass. Code looks okay otherwise.

[berekuk]

I'm still seeing the bug?

Were you on the right playground with "Next" version?

https://squiggle-website-git-pointset-imp-ed491b-quantified-uncertainty.vercel.app/playground?v=dev#code=eNqrVkpJTUsszSlxzk9JVbJSyq3QMNQx0jHWVNC1U8jMKy5ITS5RqgUA7W8L4A%3D%3D works correctly.

[OAGr]

Were you on the right playground with "Next" version?
Wait, you're right, it looks good now. I must not have been using Next.

[OAGr]

Happy for this to be merged whenever it passes build+tests.