Components: Hide small strings, other short stories #2547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b62d351 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Apply Sweep Rules to your PR?
|
OAGr
changed the title
berekuk
reviewed
Nov 17, 2023
| const shouldBeginCollapsed = ( | ||
| isRoot: boolean, | ||
| v: SqValueWithContext | ||
| ): boolean => { |
There was a problem hiding this comment.
This makes me want to write a long document on why inlining is better, again, but I'll do it some other day...
(still hope to persuade you, and the more I think about it the more convinced I become)
There was a problem hiding this comment.
I moved it much closer. It definitely seems nicer to me to be a bit separate.
packages/components/src/components/SquiggleViewer/ValueWithContextViewer.tsx
Outdated
Show resolved
Hide resolved
packages/hub/src/app/models/[owner]/[slug]/ModelSettingsButton.tsx
Outdated
Show resolved
Hide resolved
berekuk
reviewed
Nov 17, 2023
packages/components/src/components/SquiggleViewer/ValueWithContextViewer.tsx
Outdated
Show resolved
Hide resolved
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes a few very small issues.
Closes: