Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed isEqual for Squiggle Lists #2920

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Fixed isEqual for Squiggle Lists #2920

merged 1 commit into from
Jan 4, 2024

Conversation

OAGr
Copy link
Contributor

@OAGr OAGr commented Jan 4, 2024 •
edited
Loading

Closes #2907

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 4, 2024

🦋 Changeset detected

Latest commit: 7c4f9a3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@quri/squiggle-lang Patch
@quri/squiggle-components Patch
@quri/prettier-plugin-squiggle Patch
vscode-squiggle Patch
@quri/versioned-squiggle-components Patch
@quri/squiggle-textmate-grammar Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@OAGr OAGr marked this pull request as ready for review January 4, 2024 04:36
@OAGr OAGr requested a review from berekuk as a code owner January 4, 2024 04:36
@vercel Vercel
Copy link

vercel bot commented Jan 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quri-hub ✅ Ready (Inspect) Visit Preview Jan 4, 2024 4:43am
quri-ui ✅ Ready (Inspect) Visit Preview Jan 4, 2024 4:43am
squiggle-components ✅ Ready (Inspect) Visit Preview Jan 4, 2024 4:43am
squiggle-website ✅ Ready (Inspect) Visit Preview Jan 4, 2024 4:43am

@sweep-ai Sweep AI
Copy link
Contributor

sweep-ai bot commented Jan 4, 2024

Apply Sweep Rules to your PR?

  • Apply: All docstrings and comments should be up to date.
  • Apply: Ensure that all variables and functions have descriptive names.
  • Apply: Avoid using magic numbers or hard-coded values in the code.

@OAGr OAGr merged commit 3a1c31d into main Jan 4, 2024
7 checks passed
@OAGr OAGr deleted the fix-isEqual-for-lists branch January 4, 2024 04:46
berekuk
berekuk reviewed Jan 5, 2024
View reviewed changes
packages/squiggle-lang/src/value/index.ts
@@ -112,7 +112,10 @@ class VArray extends BaseValue implements Indexable {
}

for (let i = 0; i < this.value.length; i++) {
isEqual(this.value[i], other.value[i]);
const _isEqual = isEqual(this.value[i], other.value[i]);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got curious about this...

Result value must be used check issue on TS repo was opened 8 years ago (latest idea there is nodiscard keyword), eslint issue wasn't accepted either (and it would be hard to do without extra syntax).

Oh well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, that's interesting, good find

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a bug that should be easy for an LLM to detect at least.

@github-actions github-actions bot mentioned this pull request Jan 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berekuk berekuk berekuk left review comments

Assignees
No one assigned
Labels
None yet
Projects
Main project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

equal([1,2], [1,3]) is true
2 participants
@OAGr @berekuk