Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Plot Titles, Tag.all -> Tag.getAll #2925

Merged
merged 4 commits into from Jan 9, 2024
Merged

Conversation

OAGr
Copy link
Contributor

@OAGr OAGr commented Jan 6, 2024

No description provided.

@OAGr OAGr requested a review from berekuk as a code owner January 6, 2024 20:36
Copy link

changeset-bot bot commented Jan 6, 2024

🦋 Changeset detected

Latest commit: 7c290ab

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@quri/squiggle-lang Patch
@quri/squiggle-components Patch
@quri/prettier-plugin-squiggle Patch
vscode-squiggle Patch
@quri/versioned-squiggle-components Patch
@quri/squiggle-textmate-grammar Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quri-hub ✅ Ready (Inspect) Visit Preview Jan 9, 2024 7:26pm
squiggle-components ✅ Ready (Inspect) Visit Preview Jan 9, 2024 7:26pm
squiggle-website ✅ Ready (Inspect) Visit Preview Jan 9, 2024 7:26pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
quri-ui ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2024 7:26pm

Copy link
Contributor

sweep-ai bot commented Jan 6, 2024

Apply Sweep Rules to your PR?

  • Apply: All docstrings and comments should be up to date.
  • Apply: Ensure that all variables and functions have descriptive names.
  • Apply: Avoid using magic numbers or hard-coded values in the code.

Copy link

codecov bot commented Jan 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a877654) 69.84% compared to head (7c290ab) 69.79%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2925      +/-   ##
==========================================
- Coverage   69.84%   69.79%   -0.05%     
==========================================
  Files         120      120              
  Lines        6765     6771       +6     
  Branches     1444     1444              
==========================================
+ Hits         4725     4726       +1     
- Misses       2032     2037       +5     
  Partials        8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@berekuk berekuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but there's a merge conflict.

Copy link
Contributor

sweep-ai bot commented Jan 9, 2024

Sweeping

Resolving merge conflicts: track the progress here.

I'm currently resolving the merge conflicts in this PR. I will stack a new PR once I'm done.

[!CAUTION]

An error has occurred: 403 {"message": "API rate limit exceeded for 24.144.92.8. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)", "documentation_url": "https://docs.github.com/rest/overview/resources-in-the-rest-api#rate-limiting"} (tracking ID: ee8a2ccad3)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants