Fixed RV Plot #2927
Merged
Fixed RV Plot #2927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ceb2869 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Apply Sweep Rules to your PR?
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2927 +/- ##
==========================================
- Coverage 70.59% 69.78% -0.81%
==========================================
Files 119 119
Lines 6760 6762 +2
Branches 1442 1443 +1
==========================================
- Hits 4772 4719 -53
- Misses 1980 2035 +55
Partials 8 8 ☔ View full report in Codecov by Sentry. |
berekuk
reviewed
Jan 6, 2024
| @@ -63,16 +63,20 @@ const Cell: FC<{ | |||
| return <ErrorCell />; | |||
| } | |||
| const jsItem = itemResult.value.asJS(); | |||
| if (!(jsItem instanceof Map)) { | |||
| if (!(jsItem instanceof Object)) { | |||
There was a problem hiding this comment.
Many things in JS are instanceof Object:
> class X {}; (new X()) instanceof Object
true
> [] instanceof Object
true
OTOH, you do try/catch below, and rvSchema.parse is still there, so it should be fine.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully fixed Hub RV plot too, but not sure.
Closes #2833