Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common.throw() Function #2941

Merged
merged 4 commits into from Jan 10, 2024
Merged

Common.throw() Function #2941

merged 4 commits into from Jan 10, 2024

Conversation

OAGr
Copy link
Contributor

@OAGr OAGr commented Jan 9, 2024

Simple throw() function.

Closes #2933

@OAGr OAGr requested a review from berekuk as a code owner January 9, 2024 19:40
Copy link

changeset-bot bot commented Jan 9, 2024

🦋 Changeset detected

Latest commit: 19bc13c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@quri/squiggle-lang Patch
@quri/squiggle-components Patch
@quri/prettier-plugin-squiggle Patch
vscode-squiggle Patch
@quri/versioned-squiggle-components Patch
@quri/squiggle-textmate-grammar Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quri-hub ✅ Ready (Inspect) Visit Preview Jan 9, 2024 10:47pm
quri-ui ✅ Ready (Inspect) Visit Preview Jan 9, 2024 10:47pm
squiggle-components ✅ Ready (Inspect) Visit Preview Jan 9, 2024 10:47pm
squiggle-website ✅ Ready (Inspect) Visit Preview Jan 9, 2024 10:47pm

Copy link
Contributor

sweep-ai bot commented Jan 9, 2024

Apply Sweep Rules to your PR?

  • Apply: All docstrings and comments should be up to date.
  • Apply: Ensure that all variables and functions have descriptive names.
  • Apply: Avoid using magic numbers or hard-coded values in the code.

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5f9f24b) 69.78% compared to head (19bc13c) 69.72%.
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2941      +/-   ##
==========================================
- Coverage   69.78%   69.72%   -0.06%     
==========================================
  Files         120      120              
  Lines        6781     6791      +10     
  Branches     1446     1448       +2     
==========================================
+ Hits         4732     4735       +3     
- Misses       2041     2048       +7     
  Partials        8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OAGr
Copy link
Contributor Author

OAGr commented Jan 9, 2024

Wasn't sure if it makes sense to test this, it's pretty basic.

Copy link
Contributor

sweep-ai bot commented Jan 9, 2024

Sweeping

Fixing PR: track the progress here.

I'm currently fixing this PR to address the following:

[Sweep GHA Fix] The GitHub Actions run failed with the following error logs:



[!CAUTION]

An error has occurred: Message is too long, max tokens is -3515 (tracking ID: 9546f7a748)

Copy link
Collaborator

@berekuk berekuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add REThrow?

Otherwise this will render as "JS Exception: Error: ...":
Screenshot 2024-01-09 at 16 21 46

* main:
  Hot fix for Tag.hide
  Fixes Prettier bug where single-item dict key trailing comma would be removed
  Delete sweep.yaml
  CR comments
  Small fixes and adds test
  Adds changeset
  Touch-ups to notebook view
  Adds tag.notebook
  experimental-list-display
  Added changelog
  Tag.all -> Tag.getAll
  Deprecate Plot titles
  reimplement updateSquiggleLangVersion with babel
  move update-system-version to ops scripts
  reorganize release scripts
  validate package.json with zod
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Fatal Exceptions
2 participants