Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds versionAdded to Docs #2965

Merged
merged 1 commit into from Jan 12, 2024
Merged

Adds versionAdded to Docs #2965

merged 1 commit into from Jan 12, 2024

Conversation

OAGr
Copy link
Contributor

@OAGr OAGr commented Jan 12, 2024

Very simple, just adds a flag for future FR Library additions.

Right now, new functions are shown in the documentation, but some of these are only available in next, which readers have no way of telling.

This is obviously very simple functionality, just to make sure the basics are here.

@OAGr OAGr requested a review from berekuk as a code owner January 12, 2024 21:00
Copy link

changeset-bot bot commented Jan 12, 2024

🦋 Changeset detected

Latest commit: f1ef68c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@quri/squiggle-lang Patch
@quri/squiggle-components Patch
@quri/prettier-plugin-squiggle Patch
vscode-squiggle Patch
@quri/versioned-squiggle-components Patch
@quri/squiggle-textmate-grammar Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quri-hub ✅ Ready (Inspect) Visit Preview Jan 12, 2024 9:05pm
quri-ui ✅ Ready (Inspect) Visit Preview Jan 12, 2024 9:05pm
squiggle-components ✅ Ready (Inspect) Visit Preview Jan 12, 2024 9:05pm
squiggle-website ✅ Ready (Inspect) Visit Preview Jan 12, 2024 9:05pm

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (df27ef9) 69.73% compared to head (f1ef68c) 69.73%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2965   +/-   ##
=======================================
  Coverage   69.73%   69.73%           
=======================================
  Files         120      120           
  Lines        6791     6791           
  Branches     1448     1448           
=======================================
  Hits         4736     4736           
  Misses       2047     2047           
  Partials        8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@berekuk berekuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since or sinceVersion might be a slightly better name. LGTM otherwise!

@OAGr OAGr merged commit 7867967 into main Jan 12, 2024
9 checks passed
@OAGr OAGr deleted the docs-version-added branch January 12, 2024 23:26
@OAGr
Copy link
Contributor Author

OAGr commented Jan 12, 2024

I'm not a huge fan of this name, but I don't really like "since". Will keep for now.

@github-actions github-actions bot mentioned this pull request Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants