Gutter items #2980
Gutter items #2980
Conversation
OAGr
commented
Jan 18, 2024
OAGr
commented
* main: comments fix circular imports by storing tags as Values minor formatting changes split value classes to separate files
🦋 Changeset detectedLatest commit: 76dc633 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
| return uniqBy(arr.reverse(), fn).reverse(); | ||
| } | ||
|
|
||
| function visibleAstChildren(node: ASTNode): ASTNode[] { |
There was a problem hiding this comment.
I decided not to merge this into squiggle-lang, because it really is specific to the components view. It hides values with @hide tags, for example. It's also not too much code.
| ) | ||
| .map((s) => s.location.start.line - 1) | ||
| ); | ||
| return values; |
There was a problem hiding this comment.
Looking back, I don't think this refactor to use the AST was worth it yet - mainly because we're not even getting to use the AST pre-render anyway. This code will be a bit more buggy than going straight to values, as it won't always align perfectly.
…ches Gutter items patches
