Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always start dist y scale from 0 #2982

Merged
merged 1 commit into from Jan 18, 2024
Merged

Always start dist y scale from 0 #2982

merged 1 commit into from Jan 18, 2024

Conversation

berekuk
Copy link
Collaborator

@berekuk berekuk commented Jan 18, 2024

Fixes #2973.

Bug was caused by this commit: 944675f#diff-8851c71bd880ffd7487e81ac6cb185ae201ab523036f8f766a22adfffcbf6586R164

So the domain for bernoulli(50%) was [probability of 0, probability of 1], something like [0.480, 0.520].

I think always starting dist charts from 0 is fine. We won't render broken pointsets with negative values correctly, but we never really did it well.

@berekuk berekuk requested a review from OAGr as a code owner January 18, 2024 23:06
Copy link

changeset-bot bot commented Jan 18, 2024

⚠️ No Changeset found

Latest commit: d728852

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quri-hub ✅ Ready (Inspect) Visit Preview Jan 18, 2024 11:11pm
quri-ui ✅ Ready (Inspect) Visit Preview Jan 18, 2024 11:11pm
squiggle-components ✅ Ready (Inspect) Visit Preview Jan 18, 2024 11:11pm
squiggle-website ✅ Ready (Inspect) Visit Preview Jan 18, 2024 11:11pm

@OAGr
Copy link
Contributor

OAGr commented Jan 18, 2024

Fair, good fix!

@OAGr OAGr merged commit 6dfbfd6 into main Jan 18, 2024
6 checks passed
@OAGr OAGr deleted the pointset-fix branch January 18, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Discrete PointSet plot broke between 0.9.0 and 0.9.2
2 participants