Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow Foo.bar and Foo as variable names #2987

Merged
merged 3 commits into from Jan 19, 2024

Conversation

berekuk
Copy link
Collaborator

@berekuk berekuk commented Jan 19, 2024

Discussion: https://discord.com/channels/1130609991993274510/1137447110766235690/1197699906840838214

We accidentally allowed Foo = 1 in 0.9.0, but Foo.bar = 1 was allowed for a while. Fortunately, no one noticed (probably).

@berekuk berekuk requested a review from OAGr as a code owner January 19, 2024 20:14
Copy link

changeset-bot bot commented Jan 19, 2024

🦋 Changeset detected

Latest commit: c413eb8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@quri/squiggle-lang Patch
@quri/squiggle-components Patch
@quri/prettier-plugin-squiggle Patch
@quri/versioned-squiggle-components Patch
vscode-squiggle Patch
@quri/squiggle-textmate-grammar Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quri-hub ✅ Ready (Inspect) Visit Preview Jan 19, 2024 8:25pm
squiggle-website ✅ Ready (Inspect) Visit Preview Jan 19, 2024 8:25pm
2 Ignored Deployments
Name Status Preview Updated (UTC)
quri-ui ⬜️ Ignored (Inspect) Visit Preview Jan 19, 2024 8:25pm
squiggle-components ⬜️ Ignored (Inspect) Visit Preview Jan 19, 2024 8:25pm

@berekuk berekuk merged commit cd849a1 into main Jan 19, 2024
5 of 6 checks passed
@berekuk berekuk deleted the disallow-capitalized-var-names branch January 19, 2024 21:15
@github-actions github-actions bot mentioned this pull request Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants