Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect extra commas on empty lists #2997

Merged
merged 1 commit into from Jan 23, 2024
Merged

Fix incorrect extra commas on empty lists #2997

merged 1 commit into from Jan 23, 2024

Conversation

berekuk
Copy link
Collaborator

@berekuk berekuk commented Jan 23, 2024

Fixes #2995.

@berekuk berekuk requested a review from OAGr as a code owner January 23, 2024 21:00
Copy link

changeset-bot bot commented Jan 23, 2024

🦋 Changeset detected

Latest commit: 2217071

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@quri/prettier-plugin-squiggle Patch
@quri/squiggle-components Patch
@quri/versioned-squiggle-components Patch
vscode-squiggle Patch
@quri/squiggle-lang Patch
@quri/squiggle-textmate-grammar Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quri-hub ✅ Ready (Inspect) Visit Preview Jan 23, 2024 9:01pm
quri-ui ✅ Ready (Inspect) Visit Preview Jan 23, 2024 9:01pm
squiggle-components ✅ Ready (Inspect) Visit Preview Jan 23, 2024 9:01pm
squiggle-website ✅ Ready (Inspect) Visit Preview Jan 23, 2024 9:01pm

@OAGr
Copy link
Contributor

OAGr commented Jan 23, 2024

I'd prefer if the changeset had a bit more info, like, "Parser: Fix incorrect extra commas on empty lists". Not big though.

@OAGr OAGr merged commit da70e66 into main Jan 23, 2024
6 checks passed
@OAGr OAGr deleted the array-extra-comma-bug branch January 23, 2024 21:11
@berekuk
Copy link
Collaborator Author

berekuk commented Jan 24, 2024

"Parser: Fix incorrect extra commas on empty lists".

This changeset will appear only on prettier plugin changelog, so prefix would be redundant.

@github-actions github-actions bot mentioned this pull request Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Formatter adds comma to empty list, which creates compile error.
2 participants