-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default Autorun Mode #3119
Default Autorun Mode #3119
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I've added some documentation.
seed String | ||
autorunMode Boolean? | ||
sampleCount Int? | ||
xyPointLength Int? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's probably better (less complex, more explicit) to make these non-optional, and move constants from the frontend to the DB.
But we can do this later.
@@ -20,11 +24,29 @@ To deploy a migration to the production database: | |||
|
|||
## Notes on changing the schema | |||
|
|||
Editing the schema is suprisingly annoying. Make sure to follow these specific steps. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry you had to deal with this. It's actually not that bad with a few tricks (properly configured Relay extension + the trick of keeping @prisma/client
open), and you usually shouldn't be restarting TS Server on each change.
I've rewritten this section with more details, plus added a note about prisma db push
being usually a better choice than frequent migrations in development.
This saves data about the autorun mode, sample count, and xyPointLength, that then gets used in the Playground.
For now, there's no UI to change these fields - we'll just set it directly via the database.
Closes #3118 #3117