Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Autorun Mode #3119

Merged
merged 3 commits into from
Mar 24, 2024
Merged

Default Autorun Mode #3119

merged 3 commits into from
Mar 24, 2024

Conversation

OAGr
Copy link
Contributor

@OAGr OAGr commented Mar 23, 2024

This saves data about the autorun mode, sample count, and xyPointLength, that then gets used in the Playground.

For now, there's no UI to change these fields - we'll just set it directly via the database.

Closes #3118 #3117

@OAGr OAGr requested a review from berekuk as a code owner March 23, 2024 21:26
Copy link

changeset-bot bot commented Mar 23, 2024

⚠️ No Changeset found

Latest commit: b841081

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Mar 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quri-hub ✅ Ready (Inspect) Visit Preview Mar 23, 2024 9:32pm
squiggle-components ✅ Ready (Inspect) Visit Preview Mar 23, 2024 9:32pm
squiggle-website ✅ Ready (Inspect) Visit Preview Mar 23, 2024 9:32pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
quri-ui ⬜️ Ignored (Inspect) Visit Preview Mar 23, 2024 9:32pm

Copy link
Collaborator

@berekuk berekuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I've added some documentation.

seed String
autorunMode Boolean?
sampleCount Int?
xyPointLength Int?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably better (less complex, more explicit) to make these non-optional, and move constants from the frontend to the DB.

But we can do this later.

@@ -20,11 +24,29 @@ To deploy a migration to the production database:

## Notes on changing the schema

Editing the schema is suprisingly annoying. Make sure to follow these specific steps.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry you had to deal with this. It's actually not that bad with a few tricks (properly configured Relay extension + the trick of keeping @prisma/client open), and you usually shouldn't be restarting TS Server on each change.

I've rewritten this section with more details, plus added a note about prisma db push being usually a better choice than frequent migrations in development.

@berekuk berekuk merged commit 3968c1b into main Mar 24, 2024
6 checks passed
@berekuk berekuk deleted the default-autorun-mode branch March 24, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add savable model default parameters to backend
2 participants