Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow lookup function overrides & other minor cleanups #3135

Merged
merged 3 commits into from
Mar 29, 2024

Conversation

berekuk
Copy link
Collaborator

@berekuk berekuk commented Mar 29, 2024

I was looking into #3061. Didn't do it for most operators, only for [] and .foo lookups ($ is allowed symbol in var identifiers).

Also cleaned up some types and library code.

I'll merge after tests, this doesn't really need a review.

@berekuk berekuk requested a review from OAGr as a code owner March 29, 2024 01:56
Copy link

changeset-bot bot commented Mar 29, 2024

⚠️ No Changeset found

Latest commit: 438f7cd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Mar 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quri-hub ✅ Ready (Inspect) Visit Preview Mar 29, 2024 2:02am
quri-ui ✅ Ready (Inspect) Visit Preview Mar 29, 2024 2:02am
squiggle-components ✅ Ready (Inspect) Visit Preview Mar 29, 2024 2:02am
squiggle-website ✅ Ready (Inspect) Visit Preview Mar 29, 2024 2:02am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant