Fix arrow parsing; avoid extra block nodes in AST #3136
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #3110, and also fixes #2670, and also simplifies grammar and AST (see tests in diff for examples).
Previously:
Now:
The arrow bug in particular was caused by parsing let statements as lambdas first, before falling back on arbitrary expressions. I don't know why it was there; there might be some obscure case where this is a technically breaking change, but all tests are parsed and I hope it's fine.
Note that this doesn't give us any significant performance improvements; I already unwrap single-expression blocks during compilation.
(Which is good because otherwise I'd be worried about this change; I remember that some time ago skipping these block nodes wasn't safe).