Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to override title property on link parsing #237

Merged
merged 2 commits into from
Mar 11, 2019

Conversation

mstruebing
Copy link
Contributor

@mstruebing mstruebing commented Feb 28, 2019

We wanted to pass a prop title down but it gets sucked up by the parser somehow.
With this change applied it is working.

closes #238

@codecov
Copy link

codecov bot commented Feb 28, 2019

Codecov Report

Merging #237 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #237   +/-   ##
=======================================
  Coverage   99.72%   99.72%           
=======================================
  Files           1        1           
  Lines         363      363           
  Branches       57       57           
=======================================
  Hits          362      362           
  Misses          1        1
Impacted Files Coverage Δ
index.js 99.72% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac97191...88728a8. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 28, 2019

Codecov Report

Merging #237 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #237   +/-   ##
=======================================
  Coverage   99.72%   99.72%           
=======================================
  Files           1        1           
  Lines         363      363           
  Branches       57       57           
=======================================
  Hits          362      362           
  Misses          1        1
Impacted Files Coverage Δ
index.js 99.72% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac97191...8eaa5d5. Read the comment docs.

@mstruebing mstruebing changed the title change order of prop overriding allow to override title property on link parsing Feb 28, 2019
Copy link
Owner

@quantizor quantizor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one! Thank you.

@quantizor quantizor merged commit bc02b23 into quantizor:master Mar 11, 2019
@quantizor
Copy link
Owner

Published in 6.9.2

ckanthony added a commit to ckanthony/markdown-to-jsx that referenced this pull request Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using override to set title property for a Link-component doesn't work
2 participants