fix: correctly parse markdown inside of a table row when a preceding column has nested HTML elements #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quantizor
approved these changes
Aug 3, 2023
marcustisater-kivra
added a commit
to kivra/toybox
that referenced
this pull request
Oct 23, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [markdown-to-jsx](https://probablyup.github.io/markdown-to-jsx) ([source](https://togithub.com/probablyup/markdown-to-jsx)) | [`7.2.0` -> `7.3.2`](https://renovatebot.com/diffs/npm/markdown-to-jsx/7.2.0/7.3.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>probablyup/markdown-to-jsx (markdown-to-jsx)</summary> ### [`v7.3.2`](https://togithub.com/probablyup/markdown-to-jsx/releases/tag/v7.3.2) [Compare Source](https://togithub.com/probablyup/markdown-to-jsx/compare/v7.3.1...v7.3.2) fix(types): path to esm types in "exports" **Full Changelog**: quantizor/markdown-to-jsx@v7.3.1...v7.3.2 ### [`v7.3.1`](https://togithub.com/probablyup/markdown-to-jsx/releases/tag/v7.3.1) [Compare Source](https://togithub.com/probablyup/markdown-to-jsx/compare/v7.3.0...v7.3.1) #### What's Changed - add dev-time error if trying to provide bad input **Full Changelog**: quantizor/markdown-to-jsx@v7.3.0...v7.3.1 ### [`v7.3.0`](https://togithub.com/probablyup/markdown-to-jsx/releases/tag/v7.3.0) [Compare Source](https://togithub.com/probablyup/markdown-to-jsx/compare/v7.2.1...v7.3.0) #### What's Changed - chore(deps): bump word-wrap from 1.2.3 to 1.2.4 by [@​dependabot](https://togithub.com/dependabot) in [quantizor/markdown-to-jsx#505 - chore(deps): bump semver from 6.3.0 to 6.3.1 by [@​dependabot](https://togithub.com/dependabot) in [quantizor/markdown-to-jsx#504 - chore(deps): bump tough-cookie from 4.1.2 to 4.1.3 by [@​dependabot](https://togithub.com/dependabot) in [quantizor/markdown-to-jsx#503 - [#​379](https://togithub.com/probablyup/markdown-to-jsx/issues/379) - Allow more custom HTML character codes by [@​brianfryer](https://togithub.com/brianfryer) in [quantizor/markdown-to-jsx#502 - fix: correctly parse markdown inside of a table row when a preceding column has nested HTML elements by [@​gusbmurphy](https://togithub.com/gusbmurphy) in [quantizor/markdown-to-jsx#501 - add option to enforce a space between headings by [@​insanicly](https://togithub.com/insanicly) in [quantizor/markdown-to-jsx#440 - fix: Update package.json for "type": "module" with updated `size-limit` tests for `index.cjs` and `index.module.js` (replacing `index.js`) by [@​nbarrow-inspire-labs](https://togithub.com/nbarrow-inspire-labs) in [quantizor/markdown-to-jsx#500 #### New Contributors - [@​brianfryer](https://togithub.com/brianfryer) made their first contribution in [quantizor/markdown-to-jsx#502 - [@​gusbmurphy](https://togithub.com/gusbmurphy) made their first contribution in [quantizor/markdown-to-jsx#501 - [@​insanicly](https://togithub.com/insanicly) made their first contribution in [quantizor/markdown-to-jsx#440 - [@​nbarrow-inspire-labs](https://togithub.com/nbarrow-inspire-labs) made their first contribution in [quantizor/markdown-to-jsx#500 **Full Changelog**: quantizor/markdown-to-jsx@v7.2.1...v7.3.0 ### [`v7.2.1`](https://togithub.com/probablyup/markdown-to-jsx/releases/tag/v7.2.1) [Compare Source](https://togithub.com/probablyup/markdown-to-jsx/compare/v7.2.0...v7.2.1) #### What's Changed - fix: move `types` condition to the front by [@​Andarist](https://togithub.com/Andarist) in [quantizor/markdown-to-jsx#492 #### New Contributors - [@​Andarist](https://togithub.com/Andarist) made their first contribution in [quantizor/markdown-to-jsx#492 **Full Changelog**: quantizor/markdown-to-jsx@v7.2.0...v7.2.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/kivra/toybox). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi40My4yIiwidXBkYXRlZEluVmVyIjoiMzYuNDMuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Marcus Tisäter <77273035+marcustisater-kivra@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #488. The issue I found was that when parsing HTML within a markdown table row, if there are nested HTML elements, then when we enter the
parseBlockfunction and setstate._inlinetofalse, it prevents any rules usinginlineRegexorsimpleInlineRegexwhen we move on to process other cells in the table. I also added a very basic test for processing HTML within a table row because I didn't see one there. Interested to hear your feedback on this!