fix lint errors

quantonganh · Dec 4, 2023 · 5838075 · 5838075
1 parent 5a5a0aa
commit 5838075
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 2 deletions.
diff --git a/http/error.go b/http/error.go
@@ -9,8 +9,6 @@ import (
 	"github.com/rs/zerolog/hlog"
 )
 
-const errOops = "Oops! Something went wrong."
-
 type appHandler func(w http.ResponseWriter, r *http.Request) error
 
 // Error parse HTTP error and write to header and body

diff --git a/http/health.go b/http/health.go
@@ -9,5 +9,6 @@ func (s *Server) healthCheckHandler(w http.ResponseWriter, r *http.Request) {
 	w.Header().Set("Content-Type", "application/json")
 	w.WriteHeader(http.StatusOK)
 
+	//nolint:errcheck
 	io.WriteString(w, `{"alive": true}`)
 }
diff --git a/http/server_test.go b/http/server_test.go
@@ -116,6 +116,7 @@ func TestConfirmHandler(t *testing.T) {
 	assert.Equal(t, http.StatusOK, w.Code)
 	var subscriptionResp *mailbus.SubscriptionResponse
 	err = json.NewDecoder(resp.Body).Decode(&subscriptionResp)
+	require.NoError(t, err)
 	assert.Equal(t, thankyouMessage, subscriptionResp.Message)
 }
 
@@ -144,5 +145,6 @@ func TestUnsubscribeHandler(t *testing.T) {
 	assert.Equal(t, http.StatusOK, w.Code)
 	var subscriptionResp *mailbus.SubscriptionResponse
 	err = json.NewDecoder(resp.Body).Decode(&subscriptionResp)
+	require.NoError(t, err)
 	assert.Equal(t, unsubscribeMessage, subscriptionResp.Message)
 }
diff --git a/http/subscribe.go b/http/subscribe.go
@@ -109,5 +109,6 @@ func (s *Server) confirmHandler(w http.ResponseWriter, r *http.Request) error {
 func writeJSONResponse(w http.ResponseWriter, statusCode int, response interface{}) {
 	w.Header().Set("ContentType", "application/json")
 	w.WriteHeader(statusCode)
+	//nolint:errcheck
 	json.NewEncoder(w).Encode(response)
 }