adapt to jupyterlab 1.0.2 #262
Conversation
|
I'm not really able to provide a proper review, but I was surprised to find the CSS change alongside with a bump of dependencies. Is that also part of the requirements for JupyterLab 1.0.0+? Along with a PR like this, or a release following this, the following should probably also be updated: |
|
The CSS change is relate to jupyter-widgets/ipywidgets#2500 and jupyter-widgets/ipywidgets#2499 . If ipywidgets PR is accepted, then the CSS change is unnecessary. |
|
WFM thanks @qzchenwl |
| @@ -25,8 +25,8 @@ | |||
| "webpack": "^3.5.5" | |||
| }, | |||
| "dependencies": { | |||
| "@jupyter-widgets/base": "^1.0.0", | |||
| "@jupyter-widgets/controls": "^1.0.0", | |||
| "@jupyter-widgets/base": "^2.0.1", | |||
There was a problem hiding this comment.
Since we still want to support classic notebooks, my reading of jupyter-widgets/ipywidgets#2472 and https://github.com/jupyter-widgets/ipywidgets/blob/master/docs/source/changelog.md#75 is that this should change to:
"@jupyter-widgets/base": "^1.1 || ^2"
|
confirmed working on 1.1.1 |
|
We also confirm that this is working - issue 261 is causing a lot of grief - PLEASE PLEASE merge this pull request! |
|
As another potential users of qgrid, I would like to add my 👍 to this PR! |
|
Merged #275 instead. |
Fixed issue #261